Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D35844 Diff 108098 lib/CodeGen/TargetPassConfig.cpp

Changeset View

Standalone View

lib/CodeGen/TargetPassConfig.cpp

Show First 20 Lines • Show All 763 Lines • ▼ Show 20 Lines	if (addGCPasses()) {
if (PrintGCInfo)		if (PrintGCInfo)
addPass(createGCInfoPrinter(dbgs()), false, false);		addPass(createGCInfoPrinter(dbgs()), false, false);
}		}

// Basic block placement.		// Basic block placement.
if (getOptLevel() != CodeGenOpt::None)		if (getOptLevel() != CodeGenOpt::None)
addBlockPlacement();		addBlockPlacement();

		// Verify basic block incoming and outgoing cfa offset and register values.
		iterateeUnsubmitted Not Done Reply Inline Actions I thought part of the problem was that these passes should not be run generally. iteratee: I thought part of the problem was that these passes should not be run generally.
		violetavAuthorUnsubmitted Not Done Reply Inline Actions I put the added target hook in the passes themselves. Should I move it to TargetPassConfig? violetav: I put the added target hook in the passes themselves. Should I move it to TargetPassConfig?
		addPass(createCFIInfoVerifier());

addPreEmitPass();		addPreEmitPass();

		// Correct CFA calculation rule where needed by inserting appropriate CFI
		// instructions.
		addPass(createCFIInstrInserter(), false);

if (TM->Options.EnableIPRA)		if (TM->Options.EnableIPRA)
		MatzeBUnsubmitted Not Done Reply Inline Actions I'd vote to remove the `maintainsCFAInfo()` flag and simply let the targets that need it add the pass as part of `addPreEmitPass()`. Is the `, false` really necessary? I wouldn't expect the pass to produce anything that fails the machine verifier. MatzeB: - I'd vote to remove the `maintainsCFAInfo()` flag and simply let the targets that need it add…
// Collect register usage information and produce a register mask of		// Collect register usage information and produce a register mask of
// clobbered registers, to be used to optimize call sites.		// clobbered registers, to be used to optimize call sites.
addPass(createRegUsageInfoCollector());		addPass(createRegUsageInfoCollector());

addPass(&FuncletLayoutID, false);		addPass(&FuncletLayoutID, false);

addPass(&StackMapLivenessID, false);		addPass(&StackMapLivenessID, false);
addPass(&LiveDebugValuesID, false);		addPass(&LiveDebugValuesID, false);
▲ Show 20 Lines • Show All 250 Lines • Show Last 20 Lines