Differential D27028 Diff 80354 lib/IR/IntrinsicInst.cpp

Changeset View

Standalone View

lib/IR/IntrinsicInst.cpp

Show All 15 Lines
16	// hack working.	16		// hack working.
17	//	17		//
18	// In some cases, arguments to intrinsics need to be generic and are defined as	18		// In some cases, arguments to intrinsics need to be generic and are defined as
19	// type pointer to empty struct { }*. To access the real item of interest the	19		// type pointer to empty struct { }*. To access the real item of interest the
20	// cast instruction needs to be stripped away.	20		// cast instruction needs to be stripped away.
21	//	21		//
22	//===----------------------------------------------------------------------===//	22		//===----------------------------------------------------------------------===//
23		23
		24		#include "llvm/ADT/StringSwitch.h"
24	#include "llvm/IR/IntrinsicInst.h"	25		#include "llvm/IR/IntrinsicInst.h"
25	#include "llvm/IR/Constants.h"	26		#include "llvm/IR/Constants.h"
26	#include "llvm/IR/GlobalVariable.h"	27		#include "llvm/IR/GlobalVariable.h"
27	#include "llvm/IR/Metadata.h"	28		#include "llvm/IR/Metadata.h"
28	#include "llvm/IR/Module.h"	29		#include "llvm/IR/Module.h"
29	#include "llvm/Support/raw_ostream.h"	30		#include "llvm/Support/raw_ostream.h"
30	using namespace llvm;	31		using namespace llvm;
31		32
▲ Show 20 Lines • Show All 56 Lines • ▼ Show 20 Line(s)
88	Value *InstrProfIncrementInst::getStep() const {	89		Value *InstrProfIncrementInst::getStep() const {
89	if (InstrProfIncrementInstStep::classof(this)) {	90		if (InstrProfIncrementInstStep::classof(this)) {
90	return const_cast<Value *>(getArgOperand(4));	91		return const_cast<Value *>(getArgOperand(4));
91	}	92		}
92	const Module *M = getModule();	93		const Module *M = getModule();
93	LLVMContext &Context = M->getContext();	94		LLVMContext &Context = M->getContext();
94	return ConstantInt::get(Type::getInt64Ty(Context), 1);	95		return ConstantInt::get(Type::getInt64Ty(Context), 1);
95	}	96		}
		97
		98		ConstrainedFPIntrinsic::RoundingMode
		99		ConstrainedFPIntrinsic::getRoundingMode() const {
		100		Metadata *RoundingMD = cast<MetadataAsValue>(getOperand(2))->getMetadata();
		101		StringRef RoundingArg = cast<MDString>(RoundingMD)->getString();
		102
		103		// For dynamic rounding mode, we use round to nearest but we will set the
		104		// 'exact' SDNodeFlag so that the value will not be rounded.
		105		return StringSwitch<RoundingMode>(RoundingArg)
		106		.Case("round.dynamic", rmDynamic)
		107		.Case("round.tonearest", rmToNearest)
			craig.topperUnsubmitted Not Done Reply Don't use 'else' after an 'if' containing a 'return' per coding standards. craig.topper: Don't use 'else' after an 'if' containing a 'return' per coding standards.
			andrew.w.kaylorAuthorUnsubmitted Not Done Reply I can make that change. What I wanted to convey here is that this is effectively a switch statement with no uncovered cases. I suppose since there is no way to get the compiler to warn if that ever changes there is no particular benefit in doing it this way. andrew.w.kaylor: I can make that change. What I wanted to convey here is that this is effectively a switch…
		108		.Case("round.downward", rmDownward)
			craig.topperUnsubmitted Not Done Reply You could maybe use a StringSwitch. craig.topper: You could maybe use a StringSwitch.
			andrew.w.kaylorAuthorUnsubmitted Not Done Reply That would be perfect, but can I put an llvm_unreachable() in a StringSwitch? andrew.w.kaylor: That would be perfect, but can I put an llvm_unreachable() in a StringSwitch?
			craig.topperUnsubmitted Not Done Reply I think StringSwitch will assert if it doesn't find a match and there is no default specified. craig.topper: I think StringSwitch will assert if it doesn't find a match and there is no default specified.
			andrew.w.kaylorAuthorUnsubmitted Not Done Reply Yes, I saw that in the code. I wanted something that was informative in non-assert mode too. I guess the obvious solution to that is to add something like an UnreachableDefault() method to StringSwitch. andrew.w.kaylor: Yes, I saw that in the code. I wanted something that was informative in non-assert mode too.
			mehdi_aminiUnsubmitted Not Done Reply "Informative" as in "triggers a runtime failure"? Unreachable isn't the right solution, it is UB in release mode AFAIK. mehdi_amini: "Informative" as in "triggers a runtime failure"? Unreachable isn't the right solution, it is…
		109		.Case("round.upward", rmUpward)
		110		.Case("round.towardzero", rmTowardZero)
		111		.UnreachableDefault("Unexpected rounding mode argument in FP intrinsic!");
		112		}
		113
		114		ConstrainedFPIntrinsic::ExceptionBehavior
		115		ConstrainedFPIntrinsic::getExceptionBehavior() const {
		116		Metadata *ExceptionMD = cast<MetadataAsValue>(getOperand(3))->getMetadata();
		117		StringRef ExceptionArg = cast<MDString>(ExceptionMD)->getString();
		118		return StringSwitch<ExceptionBehavior>(ExceptionArg)
		119		.Case("fpexcept.ignore", ebIgnore)
		120		.Case("fpexcept.maytrap", ebMayTrap)
		121		.Case("fpexcept.strict", ebStrict)
		122		.UnreachableDefault(
		123		"Unexpected exception behavior argument in FP intrinsic!");
		124		}