Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D25263 Diff 73589 CMakeLists.txt

Changeset View

Standalone View

View Options

CMakeLists.txt

Show First 20 Lines • Show All 189 Lines • ▼ Show 20 Lines
set(DEFAULT_SYSROOT "" CACHE PATH set(DEFAULT_SYSROOT "" CACHE PATH
"Default <path> to all compiler invocations for --sysroot=<path>." ) "Default <path> to all compiler invocations for --sysroot=<path>." )
set(ENABLE_LINKER_BUILD_ID OFF CACHE BOOL "pass --build-id to ld") set(ENABLE_LINKER_BUILD_ID OFF CACHE BOOL "pass --build-id to ld")
set(ENABLE_X86_RELAX_RELOCATIONS OFF CACHE BOOL set(ENABLE_X86_RELAX_RELOCATIONS OFF CACHE BOOL
"enable x86 relax relocations by default") "enable x86 relax relocations by default")
set(CLANG_DEFAULT_LINKER "" CACHE STRING
mgornyUnsubmitted
Done
ReplyInline Actions

Is there a reason not to allow using the absolute path here, like for the command-line option?

mgorny: Is there a reason not to allow using the absolute path here, like for the command-line option?
brunoUnsubmitted
Done
ReplyInline Actions

I agree here, if we're adding a cmake options for this, it should accept full paths to the linker to be used (without any need for its type like gold, bfd, etc) as well.

Additionally, if "" maps to "ld", plain CLANG_DEFAULT_LINKER="ld" should also work here.

bruno: I agree here, if we're adding a cmake options for this, it should accept full paths to the…
HahnfeldUnsubmitted
Done
ReplyInline Actions

I agree with both points here.

Hahnfeld: I agree with both points here.
"Default linker to use (\"bfd\" or \"gold\" or \"lld\", empty for platform default")
if (NOT(CLANG_DEFAULT_LINKER STREQUAL "" OR
CLANG_DEFAULT_LINKER STREQUAL "bfd" OR
CLANG_DEFAULT_LINKER STREQUAL "gold" OR
CLANG_DEFAULT_LINKER STREQUAL "lld"))
message(WARNING "Resetting default linker to use platform default")
set(CLANG_DEFAULT_LINKER "" CACHE STRING
"Default linker to use (\"bfd\" or \"gold\" or \"lld\", empty for platform default" FORCE)
endif()
set(CLANG_DEFAULT_CXX_STDLIB "" CACHE STRING set(CLANG_DEFAULT_CXX_STDLIB "" CACHE STRING
"Default C++ stdlib to use (\"libstdc++\" or \"libc++\", empty for platform default") "Default C++ stdlib to use (\"libstdc++\" or \"libc++\", empty for platform default")
if (NOT(CLANG_DEFAULT_CXX_STDLIB STREQUAL "" OR if (NOT(CLANG_DEFAULT_CXX_STDLIB STREQUAL "" OR
CLANG_DEFAULT_CXX_STDLIB STREQUAL "libstdc++" OR CLANG_DEFAULT_CXX_STDLIB STREQUAL "libstdc++" OR
CLANG_DEFAULT_CXX_STDLIB STREQUAL "libc++")) CLANG_DEFAULT_CXX_STDLIB STREQUAL "libc++"))
message(WARNING "Resetting default C++ stdlib to use platform default") message(WARNING "Resetting default C++ stdlib to use platform default")
set(CLANG_DEFAULT_CXX_STDLIB "" CACHE STRING set(CLANG_DEFAULT_CXX_STDLIB "" CACHE STRING
"Default C++ stdlib to use (\"libstdc++\" or \"libc++\", empty for platform default" FORCE) "Default C++ stdlib to use (\"libstdc++\" or \"libc++\", empty for platform default" FORCE)
▲ Show 20 Lines • Show All 477 Lines • Show Last 20 Lines