Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D23977 Diff 72758 cmake/modules/LLDBConfig.cmake

Changeset View

Standalone View

View Options

cmake/modules/LLDBConfig.cmake

Context not available.
list(APPEND system_libs ${CURSES_LIBRARIES}) list(APPEND system_libs ${CURSES_LIBRARIES})
include_directories(${CURSES_INCLUDE_DIR}) include_directories(${CURSES_INCLUDE_DIR})
endif () endif ()
find_package(Backtrace REQUIRED)
Context not available.
tfialaUnsubmitted
Not Done
ReplyInline Actions

Hi Sylvestre!

It's hard to tell without more context, but it looks like this location has most/all configurations going through it. For OSes that don't actually have a backtrace package, I think this emits a cmake error, doesn't it?

This might need to be protected by the systems that need the backtrace package. (Probably Unix-like systems only?)

tfiala: Hi Sylvestre! It's hard to tell without more context, but it looks like this location has…
krytarowskiUnsubmitted
Not Done
ReplyInline Actions

It's sufficient to drop the REQUIRED keyword and it will be fine. ${Backtrace_LIBRARY} will be evaluated to NIL in case of lack of this dependency.

I'm unsure whether find_pacakge() might be after usage of ${Backtrace_LIBRARY}. I would reorder it at least for clarity for a reader.

krytarowski: It's sufficient to drop the `REQUIRED` keyword and it will be fine. `${Backtrace_LIBRARY}` will…