Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D20561 Diff 59342 test/Sema/address-packed.c

Changeset View

Standalone View

View Options

test/Sema/address-packed.c

  • This file was added.
// RUN: %clang_cc1 -fsyntax-only -verify %s
extern void f1(int *);
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

You should run clang-format over this file (or indeed, the entire patch).

aaron.ballman: You should run clang-format over this file (or indeed, the entire patch).
extern void f2(char *);
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

I would split this test case into two, one in Sema for C and one in SemaCXX for C++.

aaron.ballman: I would split this test case into two, one in Sema for C and one in SemaCXX for C++.
struct Ok {
char c;
int x;
};
struct __attribute__((packed)) Arguable {
char c0;
int x;
char c1;
};
union __attribute__((packed)) UnionArguable {
char c;
int x;
};
typedef struct Arguable ArguableT;
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

This is unused and can be removed.

aaron.ballman: This is unused and can be removed.
struct Arguable *get_arguable();
void g0(void) {
{
struct Ok ok;
f1(&ok.x); // no-warning
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Function should take (void) since this is C.

aaron.ballman: Function should take `(void)` since this is C.
f2(&ok.c); // no-warning
}
{
struct Arguable arguable;
f2(&arguable.c0); // no-warning
f1(&arguable.x); // expected-warning {{packed member 'x' of class or structure 'Arguable'}}
f2(&arguable.c1); // no-warning
}
{
union UnionArguable arguable;
f2(&arguable.c); // no-warning
f1(&arguable.x); // expected-warning {{packed member 'x' of class or structure 'UnionArguable'}}
}
{
ArguableT arguable;
f2(&arguable.c0); // no-warning
f1(&arguable.x); // expected-warning {{packed member 'x' of class or structure 'Arguable'}}
f2(&arguable.c1); // no-warning
}
{
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Extra space before }}.

aaron.ballman: Extra space before `}}`.
struct Arguable *arguable = get_arguable();
// These do not produce any warning because of the parentheses.
f2(&(arguable->c0)); // no-warning
f1(&(arguable->x)); // no-warning
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Should put in a comment explaining that this produces no diagnostic because of the parens.

aaron.ballman: Should put in a comment explaining that this produces no diagnostic because of the parens.
f2(&(arguable->c1)); // no-warning
}
{
ArguableT *arguable = get_arguable();
// These do not produce any warning because of the parentheses.
f2(&(arguable->c0)); // no-warning
f1(&(arguable->x)); // no-warning
f2(&(arguable->c1)); // no-warning
}
}
struct S1 {
char c;
int i __attribute__((packed));
};
int *g1(struct S1 *s1) {
return &s1->i; // expected-warning {{packed member 'i' of class or structure 'S1'}}
}
struct S2_i {
int i;
};
struct __attribute__((packed)) S2 {
char c;
struct S2_i inner;
};
int *g2(struct S2 *s2) {
return &s2->inner.i; // expected-warning {{packed member 'inner' of class or structure 'S2'}}
}
struct S2_a {
char c;
struct S2_i inner __attribute__((packed));
};
int *g2_a(struct S2_a *s2_a) {
return &s2_a->inner.i; // expected-warning {{packed member 'inner' of class or structure 'S2_a'}}
}
struct __attribute__((packed)) S3 {
char c;
struct {
int i;
} inner;
};
int *g3(struct S3 *s3) {
return &s3->inner.i; // expected-warning {{packed member 'inner' of class or structure 'S3'}}
}
struct S4 {
char c;
struct __attribute__((packed)) {
int i;
} inner;
};
int *g4(struct S4 *s4) {
return &s4->inner.i; // expected-warning {{packed member 'i' of class or structure 'S4::(anonymous)'}}
}
struct S5 {
char c;
struct {
char c1;
int i __attribute__((packed));
} inner;
};
int *g5(struct S5 *s5) {
return &s5->inner.i; // expected-warning {{packed member 'i' of class or structure 'S5::(anonymous)'}}
}