Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D136522 Diff 516117 libcxx/test/std/algorithms/alg.nonmodifying/alg.find/ranges.find_last_if_not.pass.cpp

Changeset View

Standalone View

View Options

libcxx/test/std/algorithms/alg.nonmodifying/alg.find/ranges.find_last_if_not.pass.cpp

  • This file was added.
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// <algorithm>
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20
// template<forward_iterator I, sentinel_for<I> S, class Proj = identity,
// indirect_unary_predicate<projected<I, Proj>> Pred>
// constexpr subrange<I> ranges::find_last_if_not(I first, S last, Pred pred, Proj proj = {});
// template<forward_range R, class Proj = identity,
// indirect_unary_predicate<projected<iterator_t<R>, Proj>> Pred>
// constexpr borrowed_subrange_t<R>
// ranges::find_last_if_not(R&& r, Pred pred, Proj proj = {});
#include <algorithm>
#include <array>
#include <cassert>
#include <ranges>
#include "almost_satisfies_types.h"
#include "boolean_testable.h"
#include "test_iterators.h"
struct Predicate {
bool operator()(int);
};
template <class It, class Sent = It>
concept HasFindIfNotIt = requires(It it, Sent sent) {
std::ranges::find_last_if_not(it, sent, Predicate{});
};
static_assert(HasFindIfNotIt<int*>);
static_assert(!HasFindIfNotIt<InputIteratorNotDerivedFrom>);
static_assert(!HasFindIfNotIt<InputIteratorNotIndirectlyReadable>);
static_assert(!HasFindIfNotIt<InputIteratorNotInputOrOutputIterator>);
static_assert(!HasFindIfNotIt<cpp20_input_iterator<int*>, SentinelForNotSemiregular>);
static_assert(!HasFindIfNotIt<cpp20_input_iterator<int*>, InputRangeNotSentinelEqualityComparableWith>);
static_assert(!HasFindIfNotIt<int*, int>);
static_assert(!HasFindIfNotIt<int, int*>);
template <class Pred>
concept HasFindIfNotPred = requires(int* it, Pred pred) {
std::ranges::find_last_if_not(it, it, pred);
};
static_assert(!HasFindIfNotPred<IndirectUnaryPredicateNotCopyConstructible>);
static_assert(!HasFindIfNotPred<IndirectUnaryPredicateNotPredicate>);
template <class R>
concept HasFindIfNotR = requires(R r) {
std::ranges::find_last_if_not(r, Predicate{});
};
static_assert(HasFindIfNotR<std::array<int, 0>>);
static_assert(!HasFindIfNotR<int>);
static_assert(!HasFindIfNotR<InputRangeNotDerivedFrom>);
static_assert(!HasFindIfNotR<InputRangeNotIndirectlyReadable>);
static_assert(!HasFindIfNotR<InputRangeNotInputOrOutputIterator>);
static_assert(!HasFindIfNotR<InputRangeNotSentinelSemiregular>);
static_assert(!HasFindIfNotR<InputRangeNotSentinelEqualityComparableWith>);
template <class It, class Sent = It>
constexpr void test_iterators() {
{
int a[] = {1, 2, 3, 4, 5};
std::same_as<std::ranges::subrange<It>> auto ret =
std::ranges::find_last_if_not(It(a), Sent(It(a + 5)), [c = 0](int) mutable { return c++ <= 2; });
var-constUnsubmitted
Not Done
ReplyInline Actions

Can we use a simpler predicate? These tests should check the most basic logic and be as easy to read as possible.

var-const: Can we use a simpler predicate? These tests should check the most basic logic and be as easy to…
assert(base(ret.begin()) == a + 4);
assert(*ret.begin() == 5);
}
{
int a[] = {1, 2, 3, 4, 5};
auto range = std::ranges::subrange(It(a), Sent(It(a + 5)));
std::same_as<std::ranges::subrange<It>> auto ret =
std::ranges::find_last_if_not(range, [c = 0](int) mutable { return c++ <= 2; });
assert(base(ret.begin()) == a + 4);
assert(*ret.begin() == 5);
}
}
struct NonConstComparableLValue {
friend constexpr bool operator==(const NonConstComparableLValue&, const NonConstComparableLValue&) { return false; }
friend constexpr bool operator==(NonConstComparableLValue&, NonConstComparableLValue&) { return false; }
friend constexpr bool operator==(const NonConstComparableLValue&, NonConstComparableLValue&) { return false; }
friend constexpr bool operator==(NonConstComparableLValue&, const NonConstComparableLValue&) { return true; }
};
constexpr bool test() {
test_iterators<int*>();
test_iterators<const int*>();
test_iterators<bidirectional_iterator<int*>>();
test_iterators<forward_iterator<int*>>();
test_iterators<random_access_iterator<int*>>();
test_iterators<contiguous_iterator<int*>>();
{ // check that projections are used properly and that they are called with the iterator directly
{
int a[] = {1, 2, 3, 4, 5};
auto ret = std::ranges::find_last_if_not(
a, a + 5, [&](int* i) { return i != a + 3; }, [](int& i) { return &i; });
assert(ret.data() == a + 3);
}
{
int a[] = {1, 2, 3, 4, 5};
auto ret = std::ranges::find_last_if_not(
a, [&](int* i) { return i != a + 3; }, [](int& i) { return &i; });
assert(ret.data() == a + 3);
}
}
{
// check that the first element is returned
var-constUnsubmitted
Not Done
ReplyInline Actions

Last element?

var-const: Last element?
{
struct S{
int comp;
int other;
};
S a[] = {{0, 0}, {0, 2}, {0, 1}};
auto ret = std::ranges::find_last_if_not(
a, [](int i) { return i != 0; }, &S::comp);
assert(ret.data() == a + 2);
assert(ret.data()->comp == 0);
assert(ret.data()->other == 1);
}
{
struct S {
int comp;
int other;
};
S a[] = {{0, 0}, {0, 2}, {0, 1}};
auto ret = std::ranges::find_last_if_not(
a, a + 3, [](int i) { return i != 0; }, &S::comp);
assert(ret.data() == a + 2);
assert(ret.data()->comp == 0);
assert(ret.data()->other == 1);
}
}
{ // check that end iterator is returned with no match
{
int a[] = {1, 1, 1};
auto ret = std::ranges::find_last_if_not(a, a + 3, [](int) { return false; });
assert(ret.data() == a + 2);
}
{
int a[] = {1, 1, 1};
auto ret = std::ranges::find_last_if_not(a, [](int) { return false; });
assert(ret.data() == a + 2);
}
}
{ // check that ranges::dangling is returned
[[maybe_unused]] std::same_as<std::ranges::dangling> auto ret =
std::ranges::find_last_if_not(std::array{1, 2}, [](int) { return true; });
}
{ // check that an iterator is returned with a borrowing range
int a[] = {1, 2, 3, 4};
auto ret = std::ranges::find_last_if_not(std::views::all(a), [](int) { return false; });
assert(ret.data() == a + 3);
assert(*ret.data() == 4);
}
{ // check that std::invoke is used
struct S {
int i;
};
S a[] = {S{1}, S{3}, S{2}};
auto ret = std::ranges::find_last_if_not(
a, [](int) { return true; }, &S::i);
assert(ret.data() == a + 3);
}
{ // count projection and predicate invocation count
{
int a[] = {1, 2, 3, 4};
int predicate_count = 0;
int projection_count = 0;
auto ret = std::ranges::find_last_if_not(a,a + 4,
[&](int i) { ++predicate_count; return i != 2; },
[&](int i) { ++projection_count; return i; });
assert(ret.data() == a + 1);
assert(*ret.data() == 2);
assert(predicate_count == 4);
assert(projection_count == 4);
}
{
int a[] = {1, 2, 3, 4};
int predicate_count = 0;
int projection_count = 0;
auto ret = std::ranges::find_last_if_not(a,
[&](int i) { ++predicate_count; return i != 2; },
[&](int i) { ++projection_count; return i; });
assert(ret.data() == a + 1);
assert(*ret.data() == 2);
assert(predicate_count == 4);
assert(projection_count == 4);
}
}
{ // check that the return type of `iter::operator*` doesn't change
{
NonConstComparableLValue a[] = {NonConstComparableLValue{}};
auto ret = std::ranges::find_last_if_not(a, a + 1, [](auto&& e) { return e != NonConstComparableLValue{}; });
assert(ret.data() == a);
}
{
NonConstComparableLValue a[] = {NonConstComparableLValue{}};
auto ret = std::ranges::find_last_if_not(a, [](auto&& e) { return e != NonConstComparableLValue{}; });
assert(ret.data() == a);
}
fsb4000Unsubmitted
Done
ReplyInline Actions

Should be static_assert?

fsb4000: Should be `static_assert`?
}
{ // check that an empty range works
{
std::array<int, 0> a = {};
auto ret = std::ranges::find_last_if_not(a.begin(), a.end(), [](int) { return true; });
assert(ret.data() == a.begin());
}
{
std::array<int, 0> a = {};
auto ret = std::ranges::find_last_if_not(a, [](int) { return true; });
assert(ret.data() == a.begin());
}
}
{
// check that the implicit conversion to bool works
{
int a[] = {1, 2, 3, 4};
auto ret = std::ranges::find_last_if_not(a, a + 4, [](const int& i) { return BooleanTestable{i != 3}; });
assert(ret.data() == a + 2);
}
{
int a[] = {1, 2, 3, 4};
auto ret = std::ranges::find_last_if_not(a, [](const int& b) { return BooleanTestable{b != 3}; });
assert(ret.data() == a + 2);
}
}
return true;
}
int main(int, char**) {
test();
static_assert(test());
return 0;
var-constUnsubmitted
Not Done
ReplyInline Actions

Please also update test/std/library/description/conventions/customization.point.object/niebloid.compile.pass.cpp and the *robust* test files where applicable (searching for ranges::find_if among the *robust* test files should give a good idea of which ones to update).

var-const: Please also update `test/std/library/description/conventions/customization.point.
}