Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D136522 Diff 516117 libcxx/include/__algorithm/ranges_find_last_if_not.h

Changeset View

Standalone View

View Options

libcxx/include/__algorithm/ranges_find_last_if_not.h

  • This file was added.
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef _LIBCPP___ALGORITHM_RANGES_FIND_LAST_IF_NOT_H
#define _LIBCPP___ALGORITHM_RANGES_FIND_LAST_IF_NOT_H
#include <__algorithm/ranges_find_last_if.h>
#include <__config>
#include <__functional/identity.h>
#include <__functional/invoke.h>
var-constUnsubmitted
Not Done
ReplyInline Actions

iterator_operations.h might be unnecessary.

var-const: `iterator_operations.h` might be unnecessary.
#include <__functional/ranges_operations.h>
#include <__iterator/concepts.h>
#include <__iterator/projected.h>
#include <__ranges/access.h>
#include <__ranges/concepts.h>
#include <__ranges/dangling.h>
#include <__utility/forward.h>
#include <__utility/move.h>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header
#endif
#if _LIBCPP_STD_VER >= 23
_LIBCPP_BEGIN_NAMESPACE_STD
namespace ranges {
namespace __find_last_if_not {
struct __fn {
template <forward_iterator _Ip,
sentinel_for<_Ip> _Sp,
class _Proj = identity,
indirect_unary_predicate<projected<_Ip, _Proj>> _Pred>
_LIBCPP_HIDE_FROM_ABI constexpr subrange<_Ip>
operator()(_Ip __first, _Sp __last, _Pred __pred, _Proj __proj = {}) const {
auto __not_pred = [&](auto&& __e) { return !std::invoke(__pred, std::forward<decltype(__e)>(__e)); };
var-constUnsubmitted
Not Done
ReplyInline Actions

Do we have a test that fails if we remove this forward?

var-const: Do we have a test that fails if we remove this `forward`?
return ranges::__find_last_if_impl(std::move(__first), std::move(__last), __not_pred, __proj);
MordanteUnsubmitted
Done
ReplyInline Actions

naming is hard, but let's try to use something better than just a number.
How about __not_pred since this is basically the inverse of the predicate given.

Another option is just not giving this predicate a name and write it in the return statement on the next line.

Mordante: naming is hard, but let's try to use something better than just a number. How about…
var-constUnsubmitted
Not Done
ReplyInline Actions

Very optional: __negate_pred or __negated_pred?

var-const: Very optional: `__negate_pred` or `__negated_pred`?
}
template <forward_range _Rp,
class _Proj = identity,
indirect_unary_predicate<projected<iterator_t<_Rp>, _Proj>> _Pred>
_LIBCPP_HIDE_FROM_ABI constexpr borrowed_subrange_t<_Rp>
operator()(_Rp&& __r, _Pred __pred, _Proj __proj = {}) const {
auto __not_pred = [&](auto&& __e) { return !std::invoke(__pred, std::forward<decltype(__e)>(__e)); };
var-constUnsubmitted
Not Done
ReplyInline Actions

To avoid duplicating this logic, consider instead delegating to the iterator version of find_last_if_not.

var-const: To avoid duplicating this logic, consider instead delegating to the iterator version of…
return ranges::__find_last_if_impl(ranges::begin(__r), ranges::end(__r), __not_pred, __proj);
}
};
} // namespace __find_last_if_not
inline namespace __cpo {
inline constexpr auto find_last_if_not = __find_last_if_not::__fn{};
} // namespace __cpo
} // namespace ranges
_LIBCPP_END_NAMESPACE_STD
#endif // _LIBCPP_STD_VER > 23
var-constUnsubmitted
Not Done
ReplyInline Actions

>= 23

var-const: `>= 23`
#endif // _LIBCPP___ALGORITHM_RANGES_FIND_LAST_IF_NOT_H
No newline at end of file