Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline
Differential D144331 Diff 511892 libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/parse.pass.cpp
Changeset View
Changeset View
Standalone View
Standalone View
libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/parse.pass.cpp
- This file was added.
//===----------------------------------------------------------------------===// | |||||
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | |||||
// See https://llvm.org/LICENSE.txt for license information. | |||||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||||
// | |||||
//===----------------------------------------------------------------------===// | |||||
// UNSUPPORTED: c++03, c++11, c++14, c++17, c++20 | |||||
// UNSUPPORTED: no-threads | |||||
// UNSUPPORTED: libcpp-has-no-incomplete-format | |||||
// TODO FMT Fix this test using GCC, it currently times out. | |||||
// UNSUPPORTED: gcc-12 | |||||
// <thread> | |||||
// template<class charT> | |||||
// struct formatter<thread::id, charT>; | |||||
// template<class ParseContext> | |||||
// constexpr typename ParseContext::iterator | |||||
// parse(ParseContext& ctx); | |||||
// Note this tests the basics of this function. It's tested in more detail in | |||||
// the format functions test. | |||||
#include <cassert> | |||||
#include <concepts> | |||||
#include <thread> | |||||
#include "test_format_context.h" | |||||
#include "test_macros.h" | |||||
#include "make_string.h" | |||||
#define SV(S) MAKE_STRING_VIEW(CharT, S) | |||||
template <class StringViewT> | |||||
constexpr void test_parse(StringViewT fmt) { | |||||
using CharT = typename StringViewT::value_type; | |||||
auto parse_ctx = std::basic_format_parse_context<CharT>(fmt); | |||||
std::formatter<std::thread::id, CharT> formatter; | |||||
static_assert(std::semiregular<decltype(formatter)>); | |||||
std::same_as<typename StringViewT::iterator> auto it = formatter.parse(parse_ctx); | |||||
assert(it == fmt.end() - (!fmt.empty() && fmt.back() == '}')); | |||||
} | |||||
template <class CharT> | |||||
constexpr void test_fmt() { | |||||
test_parse(SV("")); | |||||
ldionne: This seems a bit clever to me. Can we pass the expected end position as a parameter to the… | |||||
See D147885 Mordante: See D147885 | |||||
test_parse(SV("1")); | |||||
test_parse(SV("}")); | |||||
test_parse(SV("1}")); | |||||
} | |||||
constexpr bool test() { | |||||
test_fmt<char>(); | |||||
#ifndef TEST_HAS_NO_WIDE_CHARACTERS | |||||
test_fmt<wchar_t>(); | |||||
#endif | |||||
return true; | |||||
} | |||||
int main(int, char**) { | |||||
test(); | |||||
static_assert(test()); | |||||
return 0; | |||||
} |
This seems a bit clever to me. Can we pass the expected end position as a parameter to the function explicitly? So this would look like it == fmt.begin() + offset. If you have this pattern in other places, I'm OK to land the patch as-is but we could have a simple patch to change all of them.