Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Changeset View

Show All 32 Lines	void SymbolTable::addFile(InputFile *file) {
}		}

// .so file		// .so file
if (auto *f = dyn_cast<SharedFile>(file)) {		if (auto *f = dyn_cast<SharedFile>(file)) {
sharedFiles.push_back(f);		sharedFiles.push_back(f);
return;		return;
}		}

		// stub file
		if (auto *f = dyn_cast<StubFile>(file)) {
		f->parse();
		stubFiles.push_back(f);
		pmatosUnsubmitted Not Done Reply Inline Actions What happens with stub files that have duplicates? Say foo: x, y foo: z Should the dependencies be x, y, z or should this be disallowed? pmatos: What happens with stub files that have duplicates? Say foo: x, y foo: z Should the…
		sbc100AuthorUnsubmitted Done Reply Inline Actions Good point. I modified the implementation so that the dependencies are dictated only by the first stub object that contains that symbol. sbc100: Good point. I modified the implementation so that the dependencies are dictated only by the…
		return;
		}

if (config->trace)		if (config->trace)
message(toString(file));		message(toString(file));

// LLVM bitcode file		// LLVM bitcode file
if (auto *f = dyn_cast<BitcodeFile>(file)) {		if (auto *f = dyn_cast<BitcodeFile>(file)) {
f->parse();		f->parse();
bitcodeFiles.push_back(f);		bitcodeFiles.push_back(f);
return;		return;
▲ Show 20 Lines • Show All 920 Lines • Show Last 20 Lines