Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D144812 Diff 504472 mlir/include/mlir/Debug/BreakpointManagers/TagBreakpointManager.h

Changeset View

Standalone View

mlir/include/mlir/Debug/BreakpointManagers/TagBreakpointManager.h

This file was added.

				//===- TagBreakpointManager.h - Simple breakpoint Support -------- C++ --===//
				//
				// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
				// See https://llvm.org/LICENSE.txt for license information.
				// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
				//
				//===----------------------------------------------------------------------===//

				#ifndef MLIR_DEBUG_BREAKPOINTMANAGERS_TAGBREAKPOINTMANAGER_H
				#define MLIR_DEBUG_BREAKPOINTMANAGERS_TAGBREAKPOINTMANAGER_H
				jpienaarUnsubmitted Done Reply Inline Actions TODO ? :) jpienaar: TODO ? :)

				#include "mlir/Debug/BreakpointManager.h"
				#include "mlir/Debug/ExecutionContext.h"
				#include "mlir/IR/Action.h"
				#include "llvm/ADT/MapVector.h"

				namespace mlir {
				namespace tracing {

				/// Simple breakpoint matching an action "tag".
				class TagBreakpoint : public BreakpointBase<TagBreakpoint> {
				public:
				TagBreakpoint(StringRef tag) : tag(tag) {}

				void print(raw_ostream &os) const override { os << "Tag: `" << tag << '`'; }

				private:
				/// A tag to associate the TagBreakpoint with.
				rriddleUnsubmitted Done Reply Inline Actions Why `_tag`? That doesn't fit with the general naming convention. Also, std::string -> StringRef? rriddle: Why `_tag`? That doesn't fit with the general naming convention. Also, std::string ->…
				std::string tag;

				/// Allow access to `tag`.
				TykerUnsubmitted Done Reply Inline Actions Isn't this `classof` automatically generated by `BreakpointBase<TagBreakpoint>`. Tyker: Isn't this `classof` automatically generated by `BreakpointBase<TagBreakpoint>`.
				rriddleUnsubmitted Done Reply Inline Actions +1, I would expect this to be automatically provided by the CRTP class. rriddle: +1, I would expect this to be automatically provided by the CRTP class.
				mehdi_aminiAuthorUnsubmitted Done Reply Inline Actions Did you start this review a while ago and posted it just now? (I addressed this comment already) mehdi_amini: Did you start this review a while ago and posted it just now? (I addressed this comment already)
				rriddleUnsubmitted Done Reply Inline Actions Weird. Maybe I didn't refresh the page, it was still present when I was doing the review. rriddle: Weird. Maybe I didn't refresh the page, it was still present when I was doing the review.
				friend class TagBreakpointManager;
				};

				/// This is a manager to store a collection of breakpoints that trigger
				/// on tags.
				class TagBreakpointManager
				: public BreakpointManagerBase<TagBreakpointManager> {
				public:
				Breakpoint *match(const Action &action) const override {
				auto it = breakpoints.find(action.getTag());
				if (it != breakpoints.end() && it->second->isEnabled())
				return it->second.get();
				return {};
				}

				/// Add a breakpoint to the manager for the given tag and return it.
				/// If a breakpoint already exists for the given tag, return the existing
				/// instance.
				TagBreakpoint *addBreakpoint(StringRef tag) {
				auto result = breakpoints.insert({tag, nullptr});
				rriddleUnsubmitted Done Reply Inline Actions Please drop the trivial braces here. rriddle: Please drop the trivial braces here.
				auto &it = result.first;
				if (result.second)
				it->second = std::make_unique<TagBreakpoint>(tag.str());
				return it->second.get();
				}

				private:
				llvm::StringMap<std::unique_ptr<TagBreakpoint>> breakpoints;
				};

				} // namespace tracing
				} // namespace mlir

				#endif // MLIR_DEBUG_BREAKPOINTMANAGERS_TAGBREAKPOINTMANAGER_H