Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D140637 Diff 504206 llvm/include/llvm/Analysis/InlineOrder.h

Changeset View

Standalone View

llvm/include/llvm/Analysis/InlineOrder.h

Show All 26 Lines	public:
virtual T pop() = 0;		virtual T pop() = 0;

virtual void erase_if(function_ref<bool(T)> Pred) = 0;		virtual void erase_if(function_ref<bool(T)> Pred) = 0;

bool empty() { return !size(); }		bool empty() { return !size(); }
};		};

std::unique_ptr<InlineOrder<std::pair<CallBase *, int>>>		std::unique_ptr<InlineOrder<std::pair<CallBase *, int>>>
getInlineOrder(FunctionAnalysisManager &FAM, const InlineParams &Params);		getInlineOrder(FunctionAnalysisManager &FAM, const InlineParams &Params,
		ModuleAnalysisManager &MAM, Module &M);

		/// Used for dynamically registering InlineOrder as plugins
		///
		/// An inline order plugin adds a new inline order at runtime by registering
		/// an instance of PluginInlineOrderAnalysis in the current
		/// ModuleAnalysisManager.
		///
		kazuUnsubmitted Not Done Reply Inline Actions Sorry, I am slow to understand this. Is the following correct understanding? `PluginInlineOrderAnalysis` is always there, regardless of whether you have a plugin. If you actually have a plugin, we can use `Factory` in `PluginInlineOrderAnalysis` to construct a custom inline order. Now, why are we using an analysis here? Is that because it's a good hook to use? kazu: Sorry, I am slow to understand this. Is the following correct understanding?
		IBricchiAuthorUnsubmitted Done Reply Inline Actions An instance of PluginInlineOrderAnalysis only exists if it has been registered, in a normal compilation it won't exist. If it's registered then indeed it's Factory will be used to create a custom order We use an analysis here because we need the PassBuilder's ability to dynamically load passes as plugins (else we'd need to implement our own custom mechanism). IBricchi: An instance of PluginInlineOrderAnalysis only exists if it has been registered, in a normal…
		/// A plugin must implement an InlineOrderFactory and register it with a
		/// PluginInlineOrderAnalysis to the provided ModuleAnalysisManager.
		///
		/// If such a plugin has been registered
		/// llvm::getInlineOrder will return the dynamically loaded inliner order.
		///
		/// For an example plugin refer to:
		/// llvm/unittests/Analysis/InlineOrderPlugin/InlineOrderPlugin.cpp
		///
		kazuUnsubmitted Done Reply Inline Actions Could we make this variable private and provide accessors like so? static bool isRegistered() { return HasBeenRegistered; } static void unregister() { HasBeenRegistered = false; } I am suggesting this because I don't want anyone to set `HasBeenRegistered` to true except in the constructor here. kazu: Could we make this variable private and provide accessors like so? ``` static bool…

		class PluginInlineOrderAnalysis
		: public AnalysisInfoMixin<PluginInlineOrderAnalysis> {
		public:
		static AnalysisKey Key;
		static bool HasBeenRegistered;

		typedef std::unique_ptr<InlineOrder<std::pair<CallBase *, int>>> (
		*InlineOrderFactory)(FunctionAnalysisManager &FAM,
		const InlineParams &Params,
		ModuleAnalysisManager &MAM, Module &M);

		PluginInlineOrderAnalysis(InlineOrderFactory Factory) : Factory(Factory) {
		HasBeenRegistered = true;
		assert(Factory != nullptr &&
		"The plugin inline order factory should not be a null pointer.");
		}

		struct Result {
		InlineOrderFactory Factory;
		};

		Result run(Module &, ModuleAnalysisManager &) { return {Factory}; }
		Result getResult() { return {Factory}; }

		private:
		InlineOrderFactory Factory;
		};
		kazuUnsubmitted Not Done Reply Inline Actions Could we document the plugin as inline comments in `llvm/unittests/Analysis/InlineOrderPlugin/InlineOrderPlugin.cpp` or something? I am afraid that the big code block comments might diverge from what the actual code should look like. If you are OK with this idea, you might want to put a pointer to the example file here. kazu: Could we document the plugin as inline comments in…

} // namespace llvm		} // namespace llvm
#endif // LLVM_ANALYSIS_INLINEORDER_H		#endif // LLVM_ANALYSIS_INLINEORDER_H
		kazuUnsubmitted Done Reply Inline Actions `ModuleAnalysisManager`? kazu: `ModuleAnalysisManager`?