Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D145209 Diff 503773 llvm/test/Transforms/DeadArgElim/musttail-indirect.ll

Changeset View

Standalone View

View Options

llvm/test/Transforms/DeadArgElim/musttail-indirect.ll

  • This file was added.
; This will fail if we don't produce correct IR.
; RUN: opt -passes=deadargelim,verify -S < %s | FileCheck %s
nikicUnsubmitted
Done
ReplyInline Actions

verify is unnecessary, as is 2>&1, as is the CHECK-NOT. Verification failure causes a crash and will fail the test regardless of output.

Please also update update_test_checks.py.

nikic: `verify` is unnecessary, as is `2>&1`, as is the CHECK-NOT. Verification failure causes a crash…
mtrofinAuthorUnsubmitted
Done
ReplyInline Actions

done, sending a separate patch w the change in 2010-04-30-DbgInfo.ll, seems unrelated.

mtrofin: done, sending a separate patch w the change in 2010-04-30-DbgInfo.ll, seems unrelated.
nikicUnsubmitted
Done
ReplyInline Actions

This still has an unnecessary verify and doesn't use update_test_checks.

nikic: This still has an unnecessary `verify` and doesn't use update_test_checks.
mtrofinAuthorUnsubmitted
Done
ReplyInline Actions

Ah, I misunderstood - I thought you meant "run update_test_checks on the other tests" - to see if they need a refresh due to this change (I assumed).

mtrofin: Ah, I misunderstood - I thought you meant "run `update_test_checks` on the other tests" - to…
define internal i32 @test_caller(ptr %fptr, i32 %a, i32 %b) {
%r = musttail call i32 @test(ptr %fptr, i32 %a, i32 %b)
ret i32 %r
}
define internal i32 @test(ptr %fptr, i32 %a, i32 %b) {
%r = musttail call i32 %fptr(ptr %fptr, i32 %a, i32 0)
ret i32 %r
}
define internal i32 @direct_test() {
%r = musttail call i32 @foo()
ret i32 %r
}
declare i32 @foo()
define internal i32 @ping(i32 %x) {
%r = musttail call i32 @pong(i32 %x)
ret i32 %r
}
define internal i32 @pong(i32 %x) {
%cond = icmp eq i32 %x, 2
br i1 %cond, label %yes, label %no
yes:
%r1 = musttail call i32 @ping(i32 %x)
ret i32 %r1
no:
%r2 = musttail call i32 @bar(i32 %x)
ret i32 %r2
}
declare i32 @bar(i32 %x)
; CHECK: define internal i32 @test_caller
; CHECK-NEXT: %r = musttail call i32 @test
; CHECK: define internal i32 @test
; CHECK-NEXT: %r = musttail call i32 %fptr