Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D136400 Diff 498897 llvm/test/Bindings/OCaml/debuginfo.ml

Changeset View

Standalone View

View Options

llvm/test/Bindings/OCaml/debuginfo.ml

Show First 20 Lines • Show All 284 Lines • ▼ Show 20 Lines let vdi = Llvm_debuginfo.dibuild_insert_declare_before dibuilder ~storage:all
~var_info:auto_var ~expr:(Llvm_debuginfo.dibuild_expression dibuilder [||]) ~var_info:auto_var ~expr:(Llvm_debuginfo.dibuild_expression dibuilder [||])
~location ~instr:entry_term ~location ~instr:entry_term
in in
let () = Printf.printf "%s\n" (Llvm.string_of_llvalue vdi) in let () = Printf.printf "%s\n" (Llvm.string_of_llvalue vdi) in
(* CHECK: call void @llvm.dbg.declare(metadata ptr %my_alloca, metadata {{![0-9]+}}, metadata !DIExpression()), !dbg {{\![0-9]+}} (* CHECK: call void @llvm.dbg.declare(metadata ptr %my_alloca, metadata {{![0-9]+}}, metadata !DIExpression()), !dbg {{\![0-9]+}}
*) *)
let arg0 = (Llvm.params f).(0) in let arg0 = (Llvm.params f).(0) in
let arg_var = Llvm_debuginfo.dibuild_create_parameter_variable dibuilder ~scope:fun_di let arg_var = Llvm_debuginfo.dibuild_create_parameter_variable dibuilder ~scope:fun_di
~name:"my_arg" ~argno:0 ~file:file_di ~line:10 ~ty ~name:"my_arg" ~argno:1 ~file:file_di ~line:10 ~ty
alanAuthorUnsubmitted
Done
ReplyInline Actions

When I ran the tests with assertions enabled, the OCaml debuginfo test at llvm/test/Bindings/OCaml/debuginfo.ml failed with the message:

File "/home/alan/llvm-project/debug/test/Bindings/OCaml/Output/debuginfo.ml.tmp/Testsuite.ml", line 1:
Warning 70 [missing-mli]: Cannot find interface file.
File "/home/alan/llvm-project/debug/test/Bindings/OCaml/Output/debuginfo.ml.tmp/debuginfo.ml", line 1:
Warning 70 [missing-mli]: Cannot find interface file.
executable: /home/alan/llvm-project/llvm/lib/IR/DIBuilder.cpp:809: llvm::DILocalVariable* llvm::DIBuilder::createParameterVariable(llvm::DIScope*, llvm::StringRef, unsigned int, llvm::DIFile*, unsigned int, llvm::DIType*, bool, llvm::DINode::DIFlags, llvm::DINodeArray): Assertion `ArgNo && "Expected non-zero argument number for parameter"' failed.
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /home/alan/llvm-project/debug/bin/FileCheck /home/alan/llvm-project/llvm/test/Bindings/OCaml/debuginfo.ml

The docs for createParameterVariable (https://llvm.org/doxygen/classllvm_1_1DIBuilder.html#afa7c4efcb5c40c8527c13759f10ef5ed) state that the index is 1-based, so the test code with argno:0 seems to be wrong?

alan: When I ran the tests with assertions enabled, the OCaml debuginfo test at…
jberdineUnsubmitted
Not Done
ReplyInline Actions

I think you're right.

jberdine: I think you're right.
~always_preserve:false flags_zero ~always_preserve:false flags_zero
in in
let argdi = Llvm_debuginfo.dibuild_insert_declare_before dibuilder ~storage:arg0 let argdi = Llvm_debuginfo.dibuild_insert_declare_before dibuilder ~storage:arg0
~var_info:arg_var ~expr:(Llvm_debuginfo.dibuild_expression dibuilder [||]) ~var_info:arg_var ~expr:(Llvm_debuginfo.dibuild_expression dibuilder [||])
~location ~instr:entry_term ~location ~instr:entry_term
in in
let () = Printf.printf "%s\n" (Llvm.string_of_llvalue argdi) in let () = Printf.printf "%s\n" (Llvm.string_of_llvalue argdi) in
(* CHECK: call void @llvm.dbg.declare(metadata i32 %0, metadata {{![0-9]+}}, metadata !DIExpression()), !dbg {{\![0-9]+}} (* CHECK: call void @llvm.dbg.declare(metadata i32 %0, metadata {{![0-9]+}}, metadata !DIExpression()), !dbg {{\![0-9]+}}
▲ Show 20 Lines • Show All 155 Lines • Show Last 20 Lines