Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D142708 Diff 492717 llvm/include/llvm/IR/GlobalObject.h

Changeset View

Standalone View

llvm/include/llvm/IR/GlobalObject.h

Show First 20 Lines • Show All 76 Lines • ▼ Show 20 Lines	public:
/// Note that for functions this is the alignment of the code, not the		/// Note that for functions this is the alignment of the code, not the
/// alignment of a function pointer.		/// alignment of a function pointer.
MaybeAlign getAlign() const {		MaybeAlign getAlign() const {
unsigned Data = getGlobalValueSubClassData();		unsigned Data = getGlobalValueSubClassData();
unsigned AlignmentData = Data & AlignmentMask;		unsigned AlignmentData = Data & AlignmentMask;
return decodeMaybeAlign(AlignmentData);		return decodeMaybeAlign(AlignmentData);
}		}

		/// Sets the alignment attribute of the GlobalObject.
		void setAlignment(Align Align);
		efriedmaUnsubmitted Done Reply Inline Actions Not sure I understand the point of overloading setAlignment; there's an implicit conversion from Align to MaybeAlign. efriedma: Not sure I understand the point of overloading setAlignment; there's an implicit conversion…
		gchateletAuthorUnsubmitted Done Reply Inline Actions The purpose here is to define a deprecation path for downstream users. Once we've cleaned up calls in the LLVM repo we will mark the `void setAlignment(MaybeAlign Align);` with `LLVM_DEPRECATED` to help downstream users migrate to the new API. It also helps catch all call sites by marking the function deprecated and compile the codebase with `-DLLVM_ENABLE_WERROR=ON` gchatelet: The purpose here is to define a deprecation path for downstream users. Once we've cleaned up…

		/// Sets the alignment attribute of the GlobalObject.
		/// This method will be deprecated as the alignment property should always be
		/// defined.
		courbetUnsubmitted Not Done Reply Inline Actions defined* courbet: defined*
void setAlignment(MaybeAlign Align);		void setAlignment(MaybeAlign Align);

unsigned getGlobalObjectSubClassData() const {		unsigned getGlobalObjectSubClassData() const {
unsigned ValueData = getGlobalValueSubClassData();		unsigned ValueData = getGlobalValueSubClassData();
return ValueData >> GlobalObjectBits;		return ValueData >> GlobalObjectBits;
}		}

void setGlobalObjectSubClassData(unsigned Val) {		void setGlobalObjectSubClassData(unsigned Val) {
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines