Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D142592 Diff 492597 clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.h

Changeset View

Standalone View

View Options

clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.h

  • This file was added.
//===-- InlineFunctionDeclCheck.h -------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_LLVMLIBC_INLINEFUNCTIONDECLCHECK_H
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_LLVMLIBC_INLINEFUNCTIONDECLCHECK_H
#include "../ClangTidyCheck.h"
#include "../utils/FileExtensionsUtils.h"
namespace clang::tidy::llvm_libc {
/// Checks that explicitly and implicitly inline functions in headers files
/// are tagged with the LIBC_INLINE macro.
///
/// For more information about the LIBC_INLINE macro, see
/// https://libc.llvm.org/code_style.html.
///
/// For the user-facing documentation see:
/// http://clang.llvm.org/extra/clang-tidy/checks/llvmlibc/inline-function-decl-check.html
class InlineFunctionDeclCheck : public ClangTidyCheck {
public:
InlineFunctionDeclCheck(StringRef Name, ClangTidyContext *Context)
: ClangTidyCheck(Name, Context),
RawStringHeaderFileExtensions(Options.getLocalOrGlobal(
"HeaderFileExtensions", utils::defaultHeaderFileExtensions())) {
if (!utils::parseFileExtensions(RawStringHeaderFileExtensions,
HeaderFileExtensions,
utils::defaultFileExtensionDelimiters())) {
this->configurationDiag("Invalid header file extension: '%0'")
<< RawStringHeaderFileExtensions;
}
}
carlosgalvezpUnsubmitted
Done
ReplyInline Actions

Please implement constructor in the .cpp file.

carlosgalvezp: Please implement constructor in the .cpp file.
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
return LangOpts.CPlusPlus;
}
carlosgalvezpUnsubmitted
Done
ReplyInline Actions

This is OK to keep in the header as it's only one line.

carlosgalvezp: This is OK to keep in the header as it's only one line.
void storeOptions(ClangTidyOptions::OptionMap &Opts) override {
Options.store(Opts, "HeaderFileExtensions", RawStringHeaderFileExtensions);
if (!utils::parseFileExtensions(RawStringHeaderFileExtensions,
HeaderFileExtensions,
utils::defaultFileExtensionDelimiters())) {
this->configurationDiag("Invalid header file extension: '%0'")
<< RawStringHeaderFileExtensions;
}
}
carlosgalvezpUnsubmitted
Done
ReplyInline Actions

Ditto

carlosgalvezp: Ditto
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
private:
const StringRef RawStringHeaderFileExtensions;
utils::FileExtensionsSet HeaderFileExtensions;
};
} // namespace clang::tidy::llvm_libc
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_LLVMLIBC_INLINEFUNCTIONDECLCHECK_H