Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D140637 Diff 489738 llvm/unittests/Analysis/InlineOrderPlugin/InlineOrderPlugin.cpp

Changeset View

Standalone View

View Options

llvm/unittests/Analysis/InlineOrderPlugin/InlineOrderPlugin.cpp

  • This file was added.
#include "llvm/IR/Function.h"
#include "llvm/IR/Module.h"
#include "llvm/Pass.h"
#include "llvm/Passes/PassBuilder.h"
#include "llvm/Passes/PassPlugin.h"
#include "llvm/Support/CommandLine.h"
#include "llvm/Support/raw_ostream.h"
#include "llvm/Analysis/InlineOrder.h"
using namespace llvm;
namespace {
class NoFooInlineOrder : public InlineOrder<std::pair<CallBase *, int>> {
public:
NoFooInlineOrder(FunctionAnalysisManager &FAM, const InlineParams &Params,
ModuleAnalysisManager &MAM, Module &M) {
// we temporarily set the PluginInlineOrderAnalysis::HasBeenRegistered
// as false to disable the plugin loading itself and renable it later
llvm::PluginInlineOrderAnalysis::HasBeenRegistered = false;
DefaultInlineOrder = getInlineOrder(FAM, Params, MAM, M);
llvm::PluginInlineOrderAnalysis::HasBeenRegistered = true;
}
kazuUnsubmitted
Done
ReplyInline Actions

Could we say something like this?

DefaultInlineOrder = getDefaultInlineOrder(FAM, Params, MAM, M);

To do this, we would need to rename getInlineOrder to getDefaultInlineOrder, turning getInlineOrder into a mere selector:

std::unique_ptr<InlineOrder<std::pair<CallBase *, int>>>
llvm::getDefaultInlineOrder(FunctionAnalysisManager &FAM, const InlineParams &Params,
                           ModuleAnalysisManager &MAM, Module &M) {
  // The original function body goes here.
}

std::unique_ptr<InlineOrder<std::pair<CallBase *, int>>>
llvm::getInlineOrder(FunctionAnalysisManager &FAM, const InlineParams &Params,
                     ModuleAnalysisManager &MAM, Module &M) {
  if (llvm::PluginInlineOrderAnalysis::HasBeenRegistered) {
    LLVM_DEBUG(dbgs() << "    Current used priority: plugin ---- \n");
    return MAM.getResult<PluginInlineOrderAnalysis>(M).Factory(FAM, Params, MAM,
                                                               M);
  }

  return getDefaultInlineOrder(FAM, Params, MAM, M);
}
kazu: Could we say something like this? ``` DefaultInlineOrder = getDefaultInlineOrder(FAM, Params…
size_t size() override { return DefaultInlineOrder->size(); }
void push(const std::pair<CallBase *, int> &Elt) override {
// we ignore call that include foo in the name
if (Elt.first->getCalledFunction()->getName() == "foo") {
kazuUnsubmitted
Done
ReplyInline Actions

May I suggest the following?

// Ignore callees named "foo".
kazu: May I suggest the following? ``` // Ignore callees named "foo". ```
DefaultInlineOrder->push(Elt);
}
}
std::pair<CallBase *, int> pop() override {
return DefaultInlineOrder->pop();
}
void erase_if(function_ref<bool(std::pair<CallBase *, int>)> Pred) override {
DefaultInlineOrder->erase_if(Pred);
}
private:
std::unique_ptr<InlineOrder<std::pair<CallBase *, int>>> DefaultInlineOrder;
};
std::unique_ptr<InlineOrder<std::pair<CallBase *, int>>>
DefaultInlineOrderFactory(FunctionAnalysisManager &FAM,
const InlineParams &Params,
kazuUnsubmitted
Done
ReplyInline Actions

May I suggest getNoFooInlineOrder or noFooInlineOrderFactory? At least, I would drop default here because it's not the default inline order.

kazu: May I suggest `getNoFooInlineOrder` or `noFooInlineOrderFactory`? At least, I would drop…
ModuleAnalysisManager &MAM, Module &M) {
return std::make_unique<NoFooInlineOrder>(FAM, Params, MAM, M);
}
struct DefaultDynamicInlineOrder : PassInfoMixin<DefaultDynamicInlineOrder> {
PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM) {
PluginInlineOrderAnalysis DA(DefaultInlineOrderFactory);
MAM.registerPass([&] { return DA; });
return PreservedAnalyses::all();
}
};
} // namespace
/* New PM Registration */
llvm::PassPluginLibraryInfo getDefaultDynamicInlineOrderPluginInfo() {
return {LLVM_PLUGIN_API_VERSION, "DynamicDefaultInlineOrder",
kazuUnsubmitted
Not Done
ReplyInline Actions

I am not familiar with this. Would you please explain? The new pass would load the plugin or something?

kazu: I am not familiar with this. Would you please explain? The new pass would load the plugin or…
IBricchiAuthorUnsubmitted
Done
ReplyInline Actions

In the initial commit there was an unnecessary level of indirection, it has been fixed now. The plugin should just register a PluginInlineOrderAnalysis with the ModuleAnalysisManager.

IBricchi: In the initial commit there was an unnecessary level of indirection, it has been fixed now. The…
LLVM_VERSION_STRING, [](PassBuilder &PB) {
PB.registerPipelineStartEPCallback(
[](ModulePassManager &MPM, OptimizationLevel Level) {
MPM.addPass(DefaultDynamicInlineOrder());
});
PB.registerPipelineParsingCallback(
[](StringRef Name, ModulePassManager &PM,
ArrayRef<PassBuilder::PipelineElement> InnerPipeline) {
if (Name == "dynamic-inline-order") {
PM.addPass(DefaultDynamicInlineOrder());
return true;
}
return false;
});
}};
}
extern "C" LLVM_ATTRIBUTE_WEAK ::llvm::PassPluginLibraryInfo
llvmGetPassPluginInfo() {
return getDefaultDynamicInlineOrderPluginInfo();
}