Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D141310 Diff 489109 clang/test/SemaCXX/compare-function-pointer.cpp

Changeset View

Standalone View

View Options

clang/test/SemaCXX/compare-function-pointer.cpp

// RUN: %clang_cc1 -fsyntax-only -std=c++20 -verify %s // RUN: %clang_cc1 -fsyntax-only -std=c++20 -verify -Wcompare-function-pointers %s
using fp0_t = void (*)(); using fp0_t = void (*)();
using fp1_t = int (*)(); using fp1_t = int (*)();
extern fp0_t a, b; extern fp0_t a, b;
extern fp1_t c; extern fp1_t c;
bool eq0 = a == b; bool eq0 = a == b; // expected-warning {{distinct function pointers ('fp0_t' (aka 'void (*)()') and 'fp0_t')}}
bool ne0 = a != b; bool ne0 = a != b; // expected-warning {{distinct function pointers}}
cjdbUnsubmitted
Done
ReplyInline Actions

Please be sure to check that the names are output too.

cjdb: Please be sure to check that the names are output too.
bool lt0 = a < b; // expected-warning {{ordered comparison of function pointers ('fp0_t' (aka 'void (*)()') and 'fp0_t')}} bool lt0 = a < b; // expected-warning {{ordered comparison of function pointers ('fp0_t' (aka 'void (*)()') and 'fp0_t')}}
bool le0 = a <= b; // expected-warning {{ordered comparison of function pointers}} bool le0 = a <= b; // expected-warning {{ordered comparison of function pointers}}
bool gt0 = a > b; // expected-warning {{ordered comparison of function pointers}} bool gt0 = a > b; // expected-warning {{ordered comparison of function pointers}}
bool ge0 = a >= b; // expected-warning {{ordered comparison of function pointers}} bool ge0 = a >= b; // expected-warning {{ordered comparison of function pointers}}
auto tw0 = a <=> b; // expected-error {{ordered comparison of function pointers}} auto tw0 = a <=> b; // expected-error {{ordered comparison of function pointers}}
bool eq1 = a == c; // expected-error {{comparison of distinct pointer types}} bool eq1 = a == c; // expected-error {{comparison of distinct pointer types}}
// expected-warning@-1 {{distinct function pointers ('fp0_t' (aka 'void (*)()') and 'fp1_t' (aka 'int (*)()'))}}
bool ne1 = a != c; // expected-error {{comparison of distinct pointer types}} bool ne1 = a != c; // expected-error {{comparison of distinct pointer types}}
// expected-warning@-1 {{distinct function pointers}}
cjdbUnsubmitted
Done
ReplyInline Actions

It doesn't make sense to me that we would emit a warning when we're already emitting an error.

cjdb: It doesn't make sense to me that we would emit a warning when we're already emitting an error.
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

+1, this feels like we're adding more heat without any light.

aaron.ballman: +1, this feels like we're adding more heat without any light.
bool lt1 = a < c; // expected-warning {{ordered comparison of function pointers ('fp0_t' (aka 'void (*)()') and 'fp1_t' (aka 'int (*)()'))}} bool lt1 = a < c; // expected-warning {{ordered comparison of function pointers ('fp0_t' (aka 'void (*)()') and 'fp1_t' (aka 'int (*)()'))}}
// expected-error@-1 {{comparison of distinct pointer types}} // expected-error@-1 {{comparison of distinct pointer types}}
bool le1 = a <= c; // expected-warning {{ordered comparison of function pointers}} bool le1 = a <= c; // expected-warning {{ordered comparison of function pointers}}
// expected-error@-1 {{comparison of distinct pointer types}} // expected-error@-1 {{comparison of distinct pointer types}}
bool gt1 = a > c; // expected-warning {{ordered comparison of function pointers}} bool gt1 = a > c; // expected-warning {{ordered comparison of function pointers}}
// expected-error@-1 {{comparison of distinct pointer types}} // expected-error@-1 {{comparison of distinct pointer types}}
bool ge1 = a >= c; // expected-warning {{ordered comparison of function pointers}} bool ge1 = a >= c; // expected-warning {{ordered comparison of function pointers}}
// expected-error@-1 {{comparison of distinct pointer types}} // expected-error@-1 {{comparison of distinct pointer types}}
auto tw1 = a <=> c; // expected-error {{ordered comparison of function pointers}} auto tw1 = a <=> c; // expected-error {{ordered comparison of function pointers}}