Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D141133 Diff 487084 clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-capture-this-with-capture-default.rst

Changeset View

				.. title:: clang-tidy - cppcoreguidelines-avoid-capture-this-with-capture-default

				cppcoreguidelines-avoid-capture-this-with-capture-default
				=========================================================

				Warns when lambda specify a capture default and capture ``this``. The check also
				offers fix-its.
				Eugene.ZelenkoUnsubmitted Done Reply Inline Actions Please make first statement same as in Release Notes. Eugene.Zelenko: Please make first statement same as in Release Notes.

				Capture-deafults in member functions can be misleading about
				carlosgalvezpUnsubmitted Done Reply Inline Actions defaults carlosgalvezp: defaults
				whether data members are captured by value or reference. For example,
				specifying the capture default ``[=]`` will still capture data members
				by reference.

				Examples:

				.. code-block:: c++

				struct AClass {
				int DataMember;
				void misleadingLogic() {
				int local = 0;
				member = 0;
				auto f = [=]() {
				local += 1;
				member += 1;
				};
				f();
				// Here, local is 0 but member is 1
				}

				void clearLogic() {
				int local = 0;
				member = 0;
				auto f = [this, local]() {
				local += 1;
				member += 1;
				};
				f();
				// Here, local is 0 but member is 1
				}
				};

				This check implements
				`CppCoreGuideline F.54 <http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f54-if-you-capture-this-capture-all-variables-explicitly-no-default-capture>`_.