Page MenuHomePhabricator
Differential D133222 Diff 457687 llvm/lib/Support/CMakeLists.txt

Changeset View

Standalone View

View Options

llvm/lib/Support/CMakeLists.txt

Show All 19 Lines if (NOT LLVM_HAS_NOGLOBAL_CTOR_MUTEX)
string(REPLACE "-Werror=global-constructors" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) string(REPLACE "-Werror=global-constructors" "" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS})
endif() endif()
endif() endif()
if(LLVM_ENABLE_ZLIB) if(LLVM_ENABLE_ZLIB)
list(APPEND imported_libs ZLIB::ZLIB) list(APPEND imported_libs ZLIB::ZLIB)
endif() endif()
set(zstd_target none) set(zstd_target zstd::libzstd_nonexistant)
phosekUnsubmitted
Not Done
ReplyInline Actions

I'd delete this line altogether. In CMake, you don't need to define variables before you use them and there's no suitable default value here.

phosek: I'd delete this line altogether. In CMake, you don't need to define variables before you use…
if(LLVM_ENABLE_ZSTD) if(LLVM_ENABLE_ZSTD)
if(LLVM_PREFER_STATIC_ZSTD) if(TARGET zstd::libzstd_shared AND NOT LLVM_USE_STATIC_ZSTD)
if(TARGET zstd::libzstd_static)
set(zstd_target zstd::libzstd_static)
else()
set(zstd_target zstd::libzstd_shared)
endif()
else()
if(TARGET zstd::libzstd_shared)
set(zstd_target zstd::libzstd_shared) set(zstd_target zstd::libzstd_shared)
else() else()
set(zstd_target zstd::libzstd_static) set(zstd_target zstd::libzstd_static)
endif() endif()
endif() endif()
endif()
if(LLVM_ENABLE_ZSTD) if(LLVM_ENABLE_ZSTD)
list(APPEND imported_libs ${zstd_target}) list(APPEND imported_libs ${zstd_target})
endif() endif()
if( MSVC OR MINGW ) if( MSVC OR MINGW )
# libuuid required for FOLDERID_Profile usage in lib/Support/Windows/Path.inc. # libuuid required for FOLDERID_Profile usage in lib/Support/Windows/Path.inc.
# advapi32 required for CryptAcquireContextW in lib/Support/Windows/Path.inc. # advapi32 required for CryptAcquireContextW in lib/Support/Windows/Path.inc.
▲ Show 20 Lines • Show All 306 Lines • Show Last 20 Lines