Page MenuHomePhabricator
Differential D131625 Diff 455334 clang/test/SemaHLSL/Semantics/missing_entry_annotation.hlsl

Changeset View

Standalone View

View Options

clang/test/SemaHLSL/Semantics/missing_entry_annotation.hlsl

  • This file was added.
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -fsyntax-only -hlsl-entry main -verify %s
aaron.ballmanUnsubmitted
Not Done
ReplyInline Actions
- // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -fsyntax-only -hlsl-entry main -verify %s
+ // RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -fsyntax-only -hlsl-entry main -verify %s
[numthreads(1,1, 1)]

That's not needed, right?

aaron.ballman: That's not needed, right?
beanzAuthorUnsubmitted
Done
ReplyInline Actions

It shouldn't be but is because hlsl is missing from FrontendOptions::getInputKindForExtension. I'll get a patch up for that shortly.

beanz: It shouldn't be but is because hlsl is missing from `FrontendOptions::getInputKindForExtension`.
beanzAuthorUnsubmitted
Done
ReplyInline Actions

Since the change for this was pretty trivial, I pushed it in rG887bafb503c59c5ecef831c679a2b114ee6ef338

beanz: Since the change for this was pretty trivial, I pushed it in…
[numthreads(1,1, 1)]
void main(int GI) { } // expected-error{{semantic annotations must be present for all parameters of an entry function or patch constant function}} expected-note{{'GI' declared here}}