Page MenuHomePhabricator
Differential D130181 Diff 449048 clang-tools-extra/test/clang-tidy/checkers/readability/use-early-exits.cpp

Changeset View

Standalone View

View Options

clang-tools-extra/test/clang-tidy/checkers/readability/use-early-exits.cpp

  • This file was added.
// RUN: %check_clang_tidy %s readability-use-early-exits -format-style=llvm %t -- \
// RUN: -config="{CheckOptions: {readability-use-early-exits.LineCountThreshold: 2}}"
// Run the check with the braces around statements check also enabled, but
// ShortStatementLines is set so that we shouldn't add braces.
// RUN: %check_clang_tidy %s readability-use-early-exits,readability-braces-around-statements -format-style=llvm %t -- \
// RUN: -config="{CheckOptions: {readability-use-early-exits.LineCountThreshold: 2, \
// RUN: readability-braces-around-statements.ShortStatementLines: 2}}"
// Just to hit the threshold
void padLines();
void nomralFunc(int *A) {
// CHECK-MESSAGES: [[@LINE+1]]:3: warning: use early exit
if (A) {
*A = 10;
}
// CHECK-FIXES: if (!A)
// CHECK-FIXES-NEXT: return;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: *A = 10;
}
void funcWithTrailing(int *B) {
// CHECK-MESSAGES: [[@LINE+1]]:3: warning: use early exit
if (B) {
*B = 10;
}
return;
;
// CHECK-FIXES: if (!B)
// CHECK-FIXES-NEXT: return;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: *B = 10;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: return;
// CHECK-FIXES-NEXT: ;
}
void normal(int A, int B) {
while (true) { // CHECK-MESSAGES: [[@LINE+1]]:5: warning: use early exit
if (A == B) {
padLines();
}
}
// CHECK-FIXES: while (true) {
// CHECK-FIXES-NEXT: if (A != B)
// CHECK-FIXES-NEXT: continue;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: padLines();
// CHECK-FIXES-NEXT: }
// Eat continue and empty nulls
while (true) { // CHECK-MESSAGES: [[@LINE+1]]:5: warning: use early exit
if (A != B) {
padLines();
}
continue;
;
continue;
}
// CHECK-FIXES: while (true) {
// CHECK-FIXES-NEXT: if (A == B)
// CHECK-FIXES-NEXT: continue;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: padLines();
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: continue;
// CHECK-FIXES-NEXT: ;
// CHECK-FIXES-NEXT: continue;
// CHECK-FIXES-NEXT: }
}
void toShort(int A, int B) {
while (true) {
if (A == B) {
}
}
}
void hasElse(int A, int B) {
while (true) {
if (A == B) {
} else {
}
}
}
void hasTrailingStmt(int A, int B) {
while (true) {
if (A == B) {
}
padLines();
}
}
void nested(int A, int B) {
// if (A > B) {
// CHECK-MESSAGES: [[@LINE+6]]:5: warning: use early exit
// if (B < A) {
// CHECK-MESSAGES: [[@LINE+5]]:7: warning: use early exit
// if (A == B) {
// CHECK-MESSAGES: [[@LINE+4]]:9: warning: use early exit
while (true) { // Nested
if (A > B) {
if (B < A) {
if (A != B) {
padLines();
}
}
}
} // EndLoop
// CHECK-FIXES: while (true) { // Nested
// CHECK-FIXES-NEXT: if (A <= B)
// CHECK-FIXES-NEXT: continue;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: if (B >= A)
// CHECK-FIXES-NEXT: continue;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: if (A == B)
// CHECK-FIXES-NEXT: continue;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: padLines();
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: } // EndLoop
}
void badNested(bool B) {
// Ensure check doesn't check for nested `if` if outer `if` has else.
while (true) {
if (B) {
if (B) {
}
} else {
}
}
}
void semiNested(int A, int B) {
// CHECK-MESSAGES: [[@LINE+2]]:5: warning: use early exit
while (true) { // SemiNested
if (A > B) {
if (B < A) {
PiotrZSLUnsubmitted
Not Done
ReplyInline Actions
  • Missing test with if in template function & implicit specialization, just to make sure that fixes won't get to mess up.
  • Missing test with if under macro.
  • Missing test with if under switch under loop (to check if brak/continue will be used correctly, instead of return).
PiotrZSL: - Missing test with if in template function & implicit specialization, just to make sure that…
if (A != B) {
padLines();
}
} else {
}
}
}
// CHECK-FIXES: while (true) { // SemiNested
// CHECK-FIXES-NEXT: if (A <= B)
// CHECK-FIXES-NEXT: continue;
// CHECK-FIXES-EMPTY:
// CHECK-FIXES-NEXT: if (B < A) {
// CHECK-FIXES-NEXT: if (A != B) {
// CHECK-FIXES-NEXT: padLines();
// CHECK-FIXES-NEXT: }
// CHECK-FIXES-NEXT: } else {
// CHECK-FIXES-NEXT: }
// CHECK-FIXES-NEXT: }
}