Page MenuHomePhabricator
Differential D129657 Diff 444407 libcxx/include/__algorithm/set_union.h

Changeset View

Standalone View

View Options

libcxx/include/__algorithm/set_union.h

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___ALGORITHM_SET_UNION_H #ifndef _LIBCPP___ALGORITHM_SET_UNION_H
#define _LIBCPP___ALGORITHM_SET_UNION_H #define _LIBCPP___ALGORITHM_SET_UNION_H
#include <__algorithm/comp.h> #include <__algorithm/comp.h>
#include <__algorithm/comp_ref_type.h> #include <__algorithm/comp_ref_type.h>
#include <__algorithm/copy.h> #include <__algorithm/copy.h>
#include <__config> #include <__config>
#include <__iterator/iterator_traits.h> #include <__iterator/iterator_traits.h>
#include <__utility/move.h>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
template <class _Compare, class _InputIterator1, class _InputIterator2, class _OutputIterator> template <class _InIter1, class _InIter2, class _OutIter>
_LIBCPP_CONSTEXPR_AFTER_CXX17 _OutputIterator struct __set_union_result {
__set_union(_InputIterator1 __first1, _InputIterator1 __last1, _InIter1 __in1_;
_InputIterator2 __first2, _InputIterator2 __last2, _OutputIterator __result, _Compare __comp) _InIter2 __in2_;
{ _OutIter __out_;
for (; __first1 != __last1; ++__result)
{ // need a constructor as C++03 aggregate init is hard
if (__first2 == __last2) _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17
return _VSTD::copy(__first1, __last1, __result); __set_union_result(_InIter1&& __in_iter1, _InIter2&& __in_iter2, _OutIter&& __out_iter)
if (__comp(*__first2, *__first1)) : __in1_(std::move(__in_iter1)), __in2_(std::move(__in_iter2)), __out_(std::move(__out_iter)) {}
{ };
template <class _Compare, class _InIter1, class _Sent1, class _InIter2, class _Sent2, class _OutIter>
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 __set_union_result<_InIter1, _InIter2, _OutIter> __set_union(
_InIter1 __first1, _Sent1 __last1, _InIter2 __first2, _Sent2 __last2, _OutIter __result, _Compare&& __comp) {
for (; __first1 != __last1; ++__result) {
if (__first2 == __last2) {
auto __ret1 = std::__copy_impl(std::move(__first1), std::move(__last1), std::move(__result));
return __set_union_result<_InIter1, _InIter2, _OutIter>(
std::move(__ret1.first), std::move(__first2), std::move((__ret1.second)));
}
if (__comp(*__first2, *__first1)) {
*__result = *__first2; *__result = *__first2;
++__first2; ++__first2;
} } else {
else if (!__comp(*__first1, *__first2)) {
{
if (!__comp(*__first1, *__first2))
++__first2; ++__first2;
}
*__result = *__first1; *__result = *__first1;
++__first1; ++__first1;
} }
} }
return _VSTD::copy(__first2, __last2, __result); auto __ret2 = std::__copy_impl(std::move(__first2), std::move(__last2), std::move(__result));
return __set_union_result<_InIter1, _InIter2, _OutIter>(
std::move(__first1), std::move(__ret2.first), std::move((__ret2.second)));
} }
template <class _InputIterator1, class _InputIterator2, class _OutputIterator, class _Compare> template <class _InputIterator1, class _InputIterator2, class _OutputIterator, class _Compare>
inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 _OutputIterator set_union(
_OutputIterator _InputIterator1 __first1,
set_union(_InputIterator1 __first1, _InputIterator1 __last1, _InputIterator1 __last1,
_InputIterator2 __first2, _InputIterator2 __last2, _OutputIterator __result, _Compare __comp) _InputIterator2 __first2,
{ _InputIterator2 __last2,
_OutputIterator __result,
_Compare __comp) {
typedef typename __comp_ref_type<_Compare>::type _Comp_ref; typedef typename __comp_ref_type<_Compare>::type _Comp_ref;
return _VSTD::__set_union<_Comp_ref>(__first1, __last1, __first2, __last2, __result, __comp); return std::__set_union<_Comp_ref>(
var-constUnsubmitted
Done
ReplyInline Actions

Nit: move?

var-const: Nit: move?
std::move(__first1),
std::move(__last1),
std::move(__first2),
std::move(__last2),
std::move(__result),
__comp)
.__out_;
var-constUnsubmitted
Done
ReplyInline Actions

If you're already refactoring this line, might as well use _LIBCPP_HIDE_FROM_ABI instead of _LIBCPP_INLINE_VISIBILITY.

var-const: If you're already refactoring this line, might as well use `_LIBCPP_HIDE_FROM_ABI` instead of…
} }
template <class _InputIterator1, class _InputIterator2, class _OutputIterator> template <class _InputIterator1, class _InputIterator2, class _OutputIterator>
inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX17 _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_AFTER_CXX17 _OutputIterator set_union(
_OutputIterator _InputIterator1 __first1,
set_union(_InputIterator1 __first1, _InputIterator1 __last1, _InputIterator1 __last1,
_InputIterator2 __first2, _InputIterator2 __last2, _OutputIterator __result) _InputIterator2 __first2,
{ _InputIterator2 __last2,
return _VSTD::set_union(__first1, __last1, __first2, __last2, __result, _OutputIterator __result) {
return std::set_union(
std::move(__first1),
var-constUnsubmitted
Done
ReplyInline Actions

Nit: move?

var-const: Nit: move?
std::move(__last1),
std::move(__first2),
std::move(__last2),
std::move(__result),
__less<typename iterator_traits<_InputIterator1>::value_type, __less<typename iterator_traits<_InputIterator1>::value_type,
typename iterator_traits<_InputIterator2>::value_type>()); typename iterator_traits<_InputIterator2>::value_type>());
} }
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
#endif // _LIBCPP___ALGORITHM_SET_UNION_H #endif // _LIBCPP___ALGORITHM_SET_UNION_H