Please use GitHub pull requests for new patches. Phabricator shutdown timeline
Changeset View
Changeset View
Standalone View
Standalone View
clang/include/clang/Driver/Options.td
- This file is larger than 256 KB, so syntax highlighting is disabled by default.
| Show First 20 Lines • Show All 817 Lines • ▼ Show 20 Lines | def Xopenmp_target_EQ : JoinedAndSeparate<["-"], "Xopenmp-target=">, Group<CompileOnly_Group>, | ||||
| HelpText<"Pass <arg> to the target offloading toolchain identified by <triple>.">, | HelpText<"Pass <arg> to the target offloading toolchain identified by <triple>.">, | ||||
| MetaVarName<"<triple> <arg>">; | MetaVarName<"<triple> <arg>">; | ||||
| def z : Separate<["-"], "z">, Flags<[LinkerInput, RenderAsInput]>, | def z : Separate<["-"], "z">, Flags<[LinkerInput, RenderAsInput]>, | ||||
| HelpText<"Pass -z <arg> to the linker">, MetaVarName<"<arg>">, | HelpText<"Pass -z <arg> to the linker">, MetaVarName<"<arg>">, | ||||
| Group<Link_Group>; | Group<Link_Group>; | ||||
| def Xlinker : Separate<["-"], "Xlinker">, Flags<[LinkerInput, RenderAsInput]>, | def Xlinker : Separate<["-"], "Xlinker">, Flags<[LinkerInput, RenderAsInput]>, | ||||
| HelpText<"Pass <arg> to the linker">, MetaVarName<"<arg>">, | HelpText<"Pass <arg> to the linker">, MetaVarName<"<arg>">, | ||||
| Group<Link_Group>; | Group<Link_Group>; | ||||
| def Xoffload_linker : Separate<["-"], "Xoffload-linker">, | |||||
tra: This option still stands out as a sore thumb.
Could we fold it into the one below as `… | |||||
I don't think we could rework -Xlinker as it works by forwarding the arguments to the linker job, this requires some handling inside of Clang to format it properly. But I should definitely make it a single argument by just checking if the joined argument is empty. jhuber6: I don't think we could rework `-Xlinker` as it works by forwarding the arguments to the linker… | |||||
| HelpText<"Pass <arg> or <triple>=<arg> to the offload linker">, | |||||
The comment may need updating now. tra: The comment may need updating now. | |||||
Sure, I'll change it before I commit. jhuber6: Sure, I'll change it before I commit. | |||||
| MetaVarName<"<arg> <triple>">, | |||||
I think this is backwards. I think the first one here should be <triple> (the one joined with -Xoffload-linker), followd by <arg> tra: I think this is backwards. I think the first one here should be `<triple>` (the one joined with… | |||||
| Group<Link_Group>; | |||||
| def Xpreprocessor : Separate<["-"], "Xpreprocessor">, Group<Preprocessor_Group>, | def Xpreprocessor : Separate<["-"], "Xpreprocessor">, Group<Preprocessor_Group>, | ||||
| HelpText<"Pass <arg> to the preprocessor">, MetaVarName<"<arg>">; | HelpText<"Pass <arg> to the preprocessor">, MetaVarName<"<arg>">; | ||||
| def X_Flag : Flag<["-"], "X">, Group<Link_Group>; | def X_Flag : Flag<["-"], "X">, Group<Link_Group>; | ||||
| def X_Joined : Joined<["-"], "X">, IgnoredGCCCompat; | def X_Joined : Joined<["-"], "X">, IgnoredGCCCompat; | ||||
| def Z_Flag : Flag<["-"], "Z">, Group<Link_Group>; | def Z_Flag : Flag<["-"], "Z">, Group<Link_Group>; | ||||
| // FIXME: All we do with this is reject it. Remove. | // FIXME: All we do with this is reject it. Remove. | ||||
| def Z_Joined : Joined<["-"], "Z">; | def Z_Joined : Joined<["-"], "Z">; | ||||
| def all__load : Flag<["-"], "all_load">; | def all__load : Flag<["-"], "all_load">; | ||||
| ▲ Show 20 Lines • Show All 5,962 Lines • Show Last 20 Lines | |||||
This option still stands out as a sore thumb.
Could we fold it into the one below as -Xoffload-linker-all ?
Or, maybe make Xoffload_linker_arg use "Xoffload-linker" prefix and then check that the first argument is either empty (which would meand "for all") or "-<target>".
Maybe we don't even need separate "-Xoffload_linker" option(s). I wonder if it would make sense to extend the existing -Xlinker and use -Xlinker-<target> ?