Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline
Changeset View
Standalone View
libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp
| //===----------------------------------------------------------------------===// | //===----------------------------------------------------------------------===// | ||||||||||
| // | // | ||||||||||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||||||||||
| // See https://llvm.org/LICENSE.txt for license information. | // See https://llvm.org/LICENSE.txt for license information. | ||||||||||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||||||||||
| // | // | ||||||||||
| //===----------------------------------------------------------------------===// | //===----------------------------------------------------------------------===// | ||||||||||
| // test sized operator delete[] replacement. | // test sized operator delete[] replacement. | ||||||||||
| // UNSUPPORTED: sanitizer-new-delete, c++03, c++11 | // UNSUPPORTED: sanitizer-new-delete, c++03, c++11 | ||||||||||
| // NOTE: Clang does not enable sized-deallocation in C++14 and beyond by | // XFAIL: apple-clang | ||||||||||
ldionne: The comment you removed is still relevant and should be kept for these compilers, since it… | |||||||||||
| // default. It is only enabled when -fsized-deallocation is given. | |||||||||||
Maybe as a pragmatic solution // TODO(mordante) fix this test after updating clang in Docker // UNSUPPORTED: clang-17 The same for the other failing test. Then I'll fix this once the libc++ CI can be updated with this fix included. Mordante: Maybe as a pragmatic solution
```
// TODO(mordante) fix this test after updating clang in… | |||||||||||
| // XFAIL: clang, apple-clang | // Sized deallocation was added in macOS 10.12 and aligned OSes. | ||||||||||
We will also need to add the following annotation to express that the test is expected to fail when run on targets where sized deallocation wasn't available yet: // Sized deallocation was added in macOS 10.12 and aligned OSes.
// XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11}}ldionne: We will also need to add the following annotation to express that the test is expected to fail… | |||||||||||
| // XFAIL: use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11}} | |||||||||||
ldionne: | |||||||||||
This shouldn't be necessary anymore if it is enabled by default in Clang trunk, no? And in fact we definitely don't want to add these flags here, since we're trying to test the default Clang behavior. I think that's why CI is failing with a bunch of XPASSes. ldionne: This shouldn't be necessary anymore if it is enabled by default in Clang trunk, no? And in fact… | |||||||||||
MordanteUnsubmitted This // XFAIL: clang-12, clang-13 is still needed but should be // XFAIL: clang-13, clang-14. (Since the LLVM 14 release we only support these two versions.) For testing it's the easiest to remove line 147 of libcxx/utils/ci/buildkite-pipeline.yml That way all builds run. The Bootstrapping build builds clang and uses that clang to test libc++. That way we can validate which builds fail and which succeed. Maybe some more builds need to be (temporary) disabled. Once we verify that works we need to:
After the change has landed it will take some time before the change is propagated to the CI. Once it's propagated the followup patch can be landed. I'm willing to create the followup patch and land it at the proper time. Mordante: This `// XFAIL: clang-12, clang-13` is still needed but should be `// XFAIL: clang-13, clang… | |||||||||||
pcwang-theadUnsubmitted Thanks! I will have a try later. :) pcwang-thead: Thanks! I will have a try later. :) | |||||||||||
| #include <new> | #include <new> | ||||||||||
| #include <cstddef> | #include <cstddef> | ||||||||||
| #include <cstdlib> | #include <cstdlib> | ||||||||||
| #include <cassert> | #include <cassert> | ||||||||||
| #include "test_macros.h" | #include "test_macros.h" | ||||||||||
| int unsized_delete_called = 0; | int unsized_delete_called = 0; | ||||||||||
| ▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines | |||||||||||
The comment you removed is still relevant and should be kept for these compilers, since it applies to them.