Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D112921 Diff 423555 clang/lib/Driver/ToolChains/Clang.cpp

Changeset View

Standalone View

View Options

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 6,545 Lines • ▼ Show 20 Lines Args.addOptOutFlag(CmdArgs, options::OPT_fassume_sane_operator_new,
options::OPT_fno_assume_sane_operator_new); options::OPT_fno_assume_sane_operator_new);
// -frelaxed-template-template-args is off by default, as it is a severe // -frelaxed-template-template-args is off by default, as it is a severe
// breaking change until a corresponding change to template partial ordering // breaking change until a corresponding change to template partial ordering
// is provided. // is provided.
Args.addOptInFlag(CmdArgs, options::OPT_frelaxed_template_template_args, Args.addOptInFlag(CmdArgs, options::OPT_frelaxed_template_template_args,
options::OPT_fno_relaxed_template_template_args); options::OPT_fno_relaxed_template_template_args);
// -fsized-deallocation is off by default, as it is an ABI-breaking change for // -fsized-deallocation is on by default in C++14 onwards and otherwise off
// most platforms. // by default.
Args.addOptInFlag(CmdArgs, options::OPT_fsized_deallocation, Args.addOptInFlag(CmdArgs, options::OPT_fsized_deallocation,
options::OPT_fno_sized_deallocation); options::OPT_fno_sized_deallocation);
kwkUnsubmitted
Done
ReplyInline Actions

@rjmccall mentioned here that

Apple would like this to only be enabled conditionally based on deployment target.

Is this considered at all?

kwk: @rjmccall mentioned [here](https://reviews.llvm.org/D8467#3125570) that > Apple would like…
rnkUnsubmitted
Done
ReplyInline Actions

Can this be Args.AddLastArg(CmdArgs, ...);?

rnk: Can this be `Args.AddLastArg(CmdArgs, ...);`?
// -faligned-allocation is on by default in C++17 onwards and otherwise off // -faligned-allocation is on by default in C++17 onwards and otherwise off
// by default. // by default.
if (Arg *A = Args.getLastArg(options::OPT_faligned_allocation, if (Arg *A = Args.getLastArg(options::OPT_faligned_allocation,
options::OPT_fno_aligned_allocation, options::OPT_fno_aligned_allocation,
options::OPT_faligned_new_EQ)) { options::OPT_faligned_new_EQ)) {
if (A->getOption().matches(options::OPT_fno_aligned_allocation)) if (A->getOption().matches(options::OPT_fno_aligned_allocation))
CmdArgs.push_back("-fno-aligned-allocation"); CmdArgs.push_back("-fno-aligned-allocation");
else else
▲ Show 20 Lines • Show All 1,775 Lines • Show Last 20 Lines