Page MenuHomePhabricator
Differential D118743 Diff 416347 clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.h

Changeset View

Standalone View

View Options

clang-tools-extra/clang-tidy/modernize/UseInlineConstVariablesInHeadersCheck.h

  • This file was added.
//===--- UseInlineConstVariablesInHeadersCheck.h - clang-tidy ---*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MODERNIZE_USEINLINECONSTVARIABLESINHEADERSCHECK_H
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MODERNIZE_USEINLINECONSTVARIABLESINHEADERSCHECK_H
#include "../ClangTidyCheck.h"
#include "../utils/FileExtensionsUtils.h"
namespace clang {
namespace tidy {
namespace modernize {
/// Suggests switching to C++17 ``inline variables`` for non-inline const
/// variable definitions and extern const variable declarations in header files.
LegalizeAdulthoodUnsubmitted
Done
ReplyInline Actions

This block comment mentions functions, but the documentation only mentions variables.

LegalizeAdulthood: This block comment mentions functions, but the documentation only mentions variables.
IzaronAuthorUnsubmitted
Done
ReplyInline Actions

Oops, that's a typo: of course there are nothing abouth functions anywhere in the checker.

Izaron: Oops, that's a typo: of course there are nothing abouth functions anywhere in the checker.
///
/// The check supports these options:
/// - `HeaderFileExtensions`: a semicolon-separated list of filename
/// extensions of header files (The filename extension should not contain
/// "." prefix). `;h;hh;hpp;hxx` by default.
///
/// For extension-less header files, using an empty string or leaving an
/// empty string between ";" if there are other filename extensions.
/// - `CheckNonInline`: Whether to check and fix non-inline const variable
/// definitions in header files. True by default.
/// - `CheckExtern`: Whether to check extern const variable
/// declarations in header files. True by default.
class UseInlineConstVariablesInHeadersCheck : public ClangTidyCheck {
public:
Eugene.ZelenkoUnsubmitted
Done
ReplyInline Actions

I think this is excessive comment. It's regular convention.

Eugene.Zelenko: I think this is excessive comment. It's regular convention.
UseInlineConstVariablesInHeadersCheck(StringRef Name,
ClangTidyContext *Context);
bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
return LangOpts.CPlusPlus17;
}
void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
private:
const std::string RawStringHeaderFileExtensions;
const bool CheckNonInline;
const bool CheckExtern;
utils::FileExtensionsSet HeaderFileExtensions;
};
} // namespace modernize
} // namespace tidy
} // namespace clang
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_MODERNIZE_USEINLINECONSTVARIABLESINHEADERSCHECK_H