Differential D12781 Diff 41686 test/Transforms/PGOProfile/loop2.ll

Changeset View

Standalone View

test/Transforms/PGOProfile/loop2.ll

This file was added.

				; RUN: opt < %s -pgo-instr-gen -S \| FileCheck %s --check-prefix=GEN
				; RUN: llvm-profdata merge %S/Inputs/loop2.proftext -o %T/loop2.profdata
				; RUN: opt < %s -pgo-instr-use -pgo-test-profile-file=%T/loop2.profdata -S \| FileCheck %s --check-prefix=USE
				target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
				target triple = "x86_64-unknown-linux-gnu"

				; GEN: @__llvm_profile_name_test_nested_for = private constant [15 x i8] c"test_nested_for"

				define i32 @test_nested_for(i32 %r, i32 %s) {
				entry:
				silvasUnsubmitted Not Done Reply Inline Actions What is the importance of testing a nested for loop? What part of the code are you trying to exercise that isn't covered by loop1.ll? silvas: What is the importance of testing a nested for loop? What part of the code are you trying to…
				davidxlUnsubmitted Not Done Reply Inline Actions Having loop nest in the test for better coverage is fine -- but looks like we don't actually need 3-deep nest -- a 2-deep loop nest is good enough and will be easier to read. loop1.ll has a loop with top test. How about a loop test with bottom testing. Also a loop with more control flow inside the body, and a loop with early exit might be nice to have -- but those can be added later as follow ups if needed. davidxl: Having loop nest in the test for better coverage is fine -- but looks like we don't actually…
				; GEN: entry:
				; GEN-NOT: call void @llvm.instrprof.increment
				br label %for.cond.outer

				for.cond.outer:
				; GEN: for.cond.outer:
				; GEN-NOT: call void @llvm.instrprof.increment
				%i.0 = phi i32 [ 0, %entry ], [ %inc.2, %for.inc.outer ]
				%sum.0 = phi i32 [ 1, %entry ], [ %sum.1, %for.inc.outer ]
				%cmp = icmp slt i32 %i.0, %r
				br i1 %cmp, label %for.body.outer, label %for.end.outer
				; USE: br i1 %cmp, label %for.body.outer, label %for.end.outer
				; USE-SAME: !prof ![[BW_FOR_COND_OUTER:[0-9]+]]

				for.body.outer:
				; GEN: for.body.outer:
				; GEN-NOT: call void @llvm.instrprof.increment
				br label %for.cond.inner

				for.cond.inner:
				; GEN: for.cond.inner:
				; GEN-NOT: call void @llvm.instrprof.increment
				%j.0 = phi i32 [ 0, %for.body.outer ], [ %inc.1, %for.inc.inner ]
				%sum.1 = phi i32 [ %sum.0, %for.body.outer ], [ %inc, %for.inc.inner ]
				%cmp2 = icmp slt i32 %j.0, %s
				br i1 %cmp2, label %for.body.inner, label %for.end.inner
				; USE: br i1 %cmp2, label %for.body.inner, label %for.end.inner
				; USE-SAME: !prof ![[BW_FOR_COND_INNER:[0-9]+]]

				for.body.inner:
				; GEN: for.body.inner:
				; GEN-NOT: call void @llvm.instrprof.increment
				%inc = add nsw i32 %sum.1, 1
				br label %for.inc.inner

				for.inc.inner:
				; GEN: for.inc.inner:
				; GEN: call void @llvm.instrprof.increment(i8* getelementptr inbounds ([15 x i8], [15 x i8]* @__llvm_profile_name_test_nested_for, i32 0, i32 0), i64 53929068288, i32 3, i32 0)
				%inc.1 = add nsw i32 %j.0, 1
				br label %for.cond.inner

				for.end.inner:
				; GEN: for.end.inner:
				br label %for.inc.outer

				for.inc.outer:
				; GEN: for.inc.outer:
				; GEN: call void @llvm.instrprof.increment(i8* getelementptr inbounds ([15 x i8], [15 x i8]* @__llvm_profile_name_test_nested_for, i32 0, i32 0), i64 53929068288, i32 3, i32 1)
				%inc.2 = add nsw i32 %i.0, 1
				br label %for.cond.outer

				for.end.outer:
				; GEN: for.end.outer:
				; GEN: call void @llvm.instrprof.increment(i8* getelementptr inbounds ([15 x i8], [15 x i8]* @__llvm_profile_name_test_nested_for, i32 0, i32 0), i64 53929068288, i32 3, i32 2)
				ret i32 %sum.0
				}

				; USE-DAG: ![[BW_FOR_COND_OUTER]] = !{!"branch_weights", i32 10, i32 6}
				; USE-DAG: ![[BW_FOR_COND_INNER]] = !{!"branch_weights", i32 33, i32 10}