Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D108140 Diff 369147 llvm/lib/Transforms/IPO/AttributorAttributes.cpp

Changeset View

void AAMemoryLocationImpl::categorizePtrValue(

for (Value *Obj : Objects) {

// TODO: recognize the TBAA used for constant accesses.

MemoryLocationsKind MLK = NO_LOCATIONS;

assert(!isa<GEPOperator>(Obj) && "GEPs should have been stripped.");

if (isa<UndefValue>(Obj))

continue;

if (auto *Arg = dyn_cast<Argument>(Obj)) {

if (Arg->hasByValAttr())

// TODO: For now we do not treat byval arguments as local copies performed

MLK = NO_LOCAL_MEM;

// on the call edge, though, we should. To make that happen we need to

else

// teach various passes, e.g., DSE, about the copy effect of a byval. That

// would also allow us to mark functions only accessing byval arguments as

// readnone again, atguably their acceses have no effect outside of the

mlychkovUnsubmitted

Not Done

// would also allow us to mark functions only accessing byval arguments as

- // readnone again, atguably their acceses have no effect outside of the

+ // readnone again, arguably their accesses have no effect outside of the

// function, like accesses to allocas.

mlychkov:

mlychkovUnsubmitted

Not Done

The same typos are in commit message.

mlychkov: The same typos are in commit message.

// function, like accesses to allocas.

MLK = NO_ARGUMENT_MEM;

} else if (auto *GV = dyn_cast<GlobalValue>(Obj)) {

// Reading constant memory is not treated as a read "effect" by the

// function attr pass so we won't neither. Constants defined by TBAA are

// similar. (We know we do not write it because it is constant.)

if (auto *GVar = dyn_cast<GlobalVariable>(GV))

if (GVar->isConstant())

continue;