Differential D101396 Diff 344185 libcxx/test/std/iterators/predef.iterators/reverse.iterators/iterator_concept_conformance.compile.pass.cpp
Changeset View
Changeset View
Standalone View
Standalone View
libcxx/test/std/iterators/predef.iterators/reverse.iterators/iterator_concept_conformance.compile.pass.cpp
Show All 28 Lines | |||||
static_assert(common_reverse_iterator_checks<reverse_bidirectional_iterator>()); | static_assert(common_reverse_iterator_checks<reverse_bidirectional_iterator>()); | ||||
static_assert(std::bidirectional_iterator<reverse_bidirectional_iterator>); | static_assert(std::bidirectional_iterator<reverse_bidirectional_iterator>); | ||||
static_assert(!std::random_access_iterator<reverse_bidirectional_iterator>); | static_assert(!std::random_access_iterator<reverse_bidirectional_iterator>); | ||||
static_assert(!std::sized_sentinel_for<reverse_bidirectional_iterator, reverse_bidirectional_iterator>); | static_assert(!std::sized_sentinel_for<reverse_bidirectional_iterator, reverse_bidirectional_iterator>); | ||||
using reverse_random_access_iterator = std::reverse_iterator<random_access_iterator<int*>>; | using reverse_random_access_iterator = std::reverse_iterator<random_access_iterator<int*>>; | ||||
static_assert(common_reverse_iterator_checks<reverse_random_access_iterator>()); | static_assert(common_reverse_iterator_checks<reverse_random_access_iterator>()); | ||||
static_assert(std::random_access_iterator<reverse_random_access_iterator>); | static_assert(std::random_access_iterator<reverse_random_access_iterator>); | ||||
static_assert(!std::contiguous_iterator<reverse_random_access_iterator>); | |||||
static_assert(std::sized_sentinel_for<reverse_random_access_iterator, reverse_random_access_iterator>); | static_assert(std::sized_sentinel_for<reverse_random_access_iterator, reverse_random_access_iterator>); | ||||
using reverse_contiguous_iterator = std::reverse_iterator<contiguous_iterator<int*>>; | using reverse_contiguous_iterator = std::reverse_iterator<contiguous_iterator<int*>>; | ||||
static_assert(common_reverse_iterator_checks<reverse_contiguous_iterator>()); | static_assert(common_reverse_iterator_checks<reverse_contiguous_iterator>()); | ||||
static_assert(std::random_access_iterator<reverse_contiguous_iterator>); | static_assert(!std::contiguous_iterator<reverse_contiguous_iterator>); | ||||
Quuxplusone: Please keep the assert for
```
static_assert(std… | |||||
static_assert(std::sized_sentinel_for<reverse_contiguous_iterator, reverse_contiguous_iterator>); | static_assert(std::sized_sentinel_for<reverse_contiguous_iterator, reverse_contiguous_iterator>); |
Please keep the assert for
(just add the new negative assert). This also applies anywhere else in this PR that you removed a positive assert without replacing it with a stronger positive assert (if any such places exist).