Page MenuHomePhabricator
Differential D101547 Diff 342743 libcxx/test/std/ranges/range.view/view.compile.pass.cpp

Changeset View

Standalone View

View Options

libcxx/test/std/ranges/range.view/view.compile.pass.cpp

  • This file was added.
//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: libcpp-no-concepts
// <ranges>
// template<class T>
// concept view = ...;
#include <ranges>
#include "test_macros.h"
// The type would be a view, but it's not moveable.
struct NotMoveable : std::ranges::view_base {
NotMoveable() = default;
NotMoveable(NotMoveable&&) = delete;
NotMoveable& operator=(NotMoveable&&) = delete;
friend int* begin(NotMoveable&);
friend int* begin(NotMoveable const&);
friend int* end(NotMoveable&);
friend int* end(NotMoveable const&);
};
static_assert(std::ranges::range<NotMoveable>);
ldionneAuthorUnsubmitted
Done
ReplyInline Actions

@cjdb I found it very surprising that I had to provide both those overloads for the range concept to be satisfied. Is that really intended, or is that a bug in the patch that adds range (which is under review)?

ldionne: @cjdb I found it very surprising that I had to provide both those overloads for the `range`…
cjdbUnsubmitted
Done
ReplyInline Actions

This is a very annoying artefact of the poison pills. @tcanens, what's the likelihood we can get LWG to review their existence?

cjdb: This is a very annoying artefact of the poison pills. @tcanens, what's the likelihood we can…
tcanensUnsubmitted
Done
ReplyInline Actions

Would definitely take a paper and implementation experience.

tcanens: Would definitely take a paper and implementation experience.
static_assert(!std::movable<NotMoveable>);
static_assert(std::default_initializable<NotMoveable>);
static_assert(std::ranges::enable_view<NotMoveable>);
static_assert(!std::ranges::view<NotMoveable>);
// The type would be a view, but it's not default initializable
zoecarverUnsubmitted
Done
ReplyInline Actions

Nit: spacing (and elsewhere).

zoecarver: Nit: spacing (and elsewhere).
ldionneAuthorUnsubmitted
Done
ReplyInline Actions

So the original reason to indent it that way was to make the thing we're actually trying to test stand out. But I guess I'll remove it :-).

ldionne: So the original reason to indent it that way was to make the thing we're actually trying to…
struct NotDefaultInit : std::ranges::view_base {
NotDefaultInit() = delete;
friend int* begin(NotDefaultInit&);
friend int* begin(NotDefaultInit const&);
friend int* end(NotDefaultInit&);
friend int* end(NotDefaultInit const&);
};
static_assert(std::ranges::range<NotDefaultInit>);
static_assert(std::movable<NotDefaultInit>);
static_assert(!std::default_initializable<NotDefaultInit>);
static_assert(std::ranges::enable_view<NotDefaultInit>);
static_assert(!std::ranges::view<NotDefaultInit>);
// The type would be a view, but it doesn't enable it with enable_view
struct NotExplicitlyEnabled {
NotExplicitlyEnabled() = default;
NotExplicitlyEnabled(NotExplicitlyEnabled&&) = default;
NotExplicitlyEnabled& operator=(NotExplicitlyEnabled&&) = default;
friend int* begin(NotExplicitlyEnabled&);
friend int* begin(NotExplicitlyEnabled const&);
friend int* end(NotExplicitlyEnabled&);
friend int* end(NotExplicitlyEnabled const&);
};
static_assert(std::ranges::range<NotExplicitlyEnabled>);
static_assert(std::movable<NotExplicitlyEnabled>);
static_assert(std::default_initializable<NotExplicitlyEnabled>);
static_assert(!std::ranges::enable_view<NotExplicitlyEnabled>);
static_assert(!std::ranges::view<NotExplicitlyEnabled>);
// The type has everything else, but it's not a range
struct NotARange : std::ranges::view_base {
NotARange() = default;
NotARange(NotARange&&) = default;
NotARange& operator=(NotARange&&) = default;
};
static_assert(!std::ranges::range<NotARange>);
static_assert(std::movable<NotARange>);
static_assert(std::default_initializable<NotARange>);
static_assert(std::ranges::enable_view<NotARange>);
static_assert(!std::ranges::view<NotARange>);
// The type satisfies all requirements
struct View : std::ranges::view_base {
View() = default;
View(View&&) = default;
View& operator=(View&&) = default;
friend int* begin(View&);
friend int* begin(View const&);
friend int* end(View&);
friend int* end(View const&);
};
static_assert(std::ranges::range<View>);
static_assert(std::movable<View>);
static_assert(std::default_initializable<View>);
static_assert(std::ranges::enable_view<View>);
static_assert(std::ranges::view<View>);