Changeset View
Standalone View
libcxx/include/__config
| Show First 20 Lines • Show All 842 Lines • ▼ Show 20 Lines | |||||
| #else | #else | ||||
| # define _LIBCPP_CONSTEVAL consteval | # define _LIBCPP_CONSTEVAL consteval | ||||
| #endif | #endif | ||||
| #if !defined(__cpp_concepts) || __cpp_concepts < 201907L | #if !defined(__cpp_concepts) || __cpp_concepts < 201907L | ||||
| #define _LIBCPP_HAS_NO_CONCEPTS | #define _LIBCPP_HAS_NO_CONCEPTS | ||||
| #endif | #endif | ||||
| #if _LIBCPP_STD_VER < 20 || defined(_LIBCPP_HAS_NO_CONCEPTS) | |||||
Quuxplusone: Please use `<= 17`, for consistency with similar lines in this file. (We tend to guard C++2a… | |||||
cjdbAuthorUnsubmitted Not Done ReplyInline Actions
Done.
Not sure I'm following this line of thought, so I'm leaving the comment as unresolved for now. cjdb: > Please use `<= 17`, for consistency with similar lines in this file.
Done.
> (We tend to… | |||||
zoecarverUnsubmitted Not Done ReplyInline Actions
I don't think this is needed anymore, because C++20 has been released. We did this pre-c++20 (when it was still C++2a) because we weren't sure it would be released in C++20 (i.e., if there was a global pandemic...). But, it was still released on time, and it is C++20, so I think we can guard on that now. zoecarver: > Not sure I'm following this line of thought, so I'm leaving the comment as unresolved for now. | |||||
cjdbAuthorUnsubmitted Not Done ReplyInline ActionsI still don't understand, sorry 😭 cjdb: I still don't understand, sorry 😭 | |||||
| #define _LIBCPP_HAS_NO_RANGES | |||||
FWIW, I'm fine with defining this for now, however as soon as we only support compilers that implement concepts, we will get rid of this and instead use just #if _LIBCPP_STD_VER >= 20 to guard concepts code. Agreed? ldionne: FWIW, I'm fine with defining this for now, however as soon as we only support compilers that… | |||||
| #endif | |||||
| #ifdef _LIBCPP_CXX03_LANG | #ifdef _LIBCPP_CXX03_LANG | ||||
| # define _LIBCPP_DEFAULT {} | # define _LIBCPP_DEFAULT {} | ||||
| #else | #else | ||||
| # define _LIBCPP_DEFAULT = default; | # define _LIBCPP_DEFAULT = default; | ||||
| #endif | #endif | ||||
| #ifdef _LIBCPP_CXX03_LANG | #ifdef _LIBCPP_CXX03_LANG | ||||
| # define _LIBCPP_EQUAL_DELETE | # define _LIBCPP_EQUAL_DELETE | ||||
| ▲ Show 20 Lines • Show All 616 Lines • Show Last 20 Lines | |||||
Please use <= 17, for consistency with similar lines in this file. (We tend to guard C++2a stuff on > 17. I don't think there's anything special about the Ranges stuff in this respect, right?)