Page MenuHomePhabricator
Differential D96394 Diff 322604 llvm/lib/Target/AVR/AVRISelLowering.cpp

Changeset View

Standalone View

View Options

llvm/lib/Target/AVR/AVRISelLowering.cpp

Context not available.
AVRTargetLowering::getRegForInlineAsmConstraint(const TargetRegisterInfo *TRI, AVRTargetLowering::getRegForInlineAsmConstraint(const TargetRegisterInfo *TRI,
StringRef Constraint, StringRef Constraint,
MVT VT) const { MVT VT) const {
// We only support i8 and i16.
//
//:FIXME: remove this assert for now since it gets sometimes executed
// assert((VT == MVT::i16 || VT == MVT::i8) && "Wrong operand type.");
aykevlUnsubmitted
Done
ReplyInline Actions

Why did you remove this assert entirely? It looks like a sensible assert.

aykevl: Why did you remove this assert entirely? It looks like a sensible assert.
benshi001AuthorUnsubmitted
Done
ReplyInline Actions

First, the assert should not be open since llvm will crash if user specified an i32 variable in inline assembly.

Second, avr-gcc does generate correct asm code for i32/i64, but llvm-avr does not. And I plan to do a further check on that.

Any way, the commented assert is unnecessary.

benshi001: First, the assert should not be open since llvm will crash if user specified an i32 variable in…
if (Constraint.size() == 1) { if (Constraint.size() == 1) {
switch (Constraint[0]) { switch (Constraint[0]) {
case 'a': // Simple upper registers r16..r23. case 'a': // Simple upper registers r16..r23.
return std::make_pair(0U, &AVR::LD8loRegClass); if (VT == MVT::i8)
return std::make_pair(0U, &AVR::LD8loRegClass);
else if (VT == MVT::i16)
return std::make_pair(0U, &AVR::DREGSLD8loRegClass);
break;
case 'b': // Base pointer registers: y, z. case 'b': // Base pointer registers: y, z.
return std::make_pair(0U, &AVR::PTRDISPREGSRegClass); if (VT == MVT::i8 || VT == MVT::i16)
return std::make_pair(0U, &AVR::PTRDISPREGSRegClass);
break;
case 'd': // Upper registers r16..r31. case 'd': // Upper registers r16..r31.
return std::make_pair(0U, &AVR::LD8RegClass); if (VT == MVT::i8)
return std::make_pair(0U, &AVR::LD8RegClass);
else if (VT == MVT::i16)
return std::make_pair(0U, &AVR::DLDREGSRegClass);
break;
case 'l': // Lower registers r0..r15. case 'l': // Lower registers r0..r15.
return std::make_pair(0U, &AVR::GPR8loRegClass); if (VT == MVT::i8)
return std::make_pair(0U, &AVR::GPR8loRegClass);
else if (VT == MVT::i16)
return std::make_pair(0U, &AVR::DREGSloRegClass);
break;
case 'e': // Pointer register pairs: x, y, z. case 'e': // Pointer register pairs: x, y, z.
return std::make_pair(0U, &AVR::PTRREGSRegClass); if (VT == MVT::i8 || VT == MVT::i16)
return std::make_pair(0U, &AVR::PTRREGSRegClass);
break;
case 'q': // Stack pointer register: SPH:SPL. case 'q': // Stack pointer register: SPH:SPL.
return std::make_pair(0U, &AVR::GPRSPRegClass); return std::make_pair(0U, &AVR::GPRSPRegClass);
case 'r': // Any register: r0..r31. case 'r': // Any register: r0..r31.
if (VT == MVT::i8) if (VT == MVT::i8)
return std::make_pair(0U, &AVR::GPR8RegClass); return std::make_pair(0U, &AVR::GPR8RegClass);
else if (VT == MVT::i16)
return std::make_pair(0U, &AVR::DREGSRegClass); return std::make_pair(0U, &AVR::DREGSRegClass);
break;
case 't': // Temporary register: r0. case 't': // Temporary register: r0.
return std::make_pair(unsigned(AVR::R0), &AVR::GPR8RegClass); if (VT == MVT::i8)
return std::make_pair(unsigned(AVR::R0), &AVR::GPR8RegClass);
break;
case 'w': // Special upper register pairs: r24, r26, r28, r30. case 'w': // Special upper register pairs: r24, r26, r28, r30.
return std::make_pair(0U, &AVR::IWREGSRegClass); if (VT == MVT::i8 || VT == MVT::i16)
return std::make_pair(0U, &AVR::IWREGSRegClass);
break;
case 'x': // Pointer register pair X: r27:r26. case 'x': // Pointer register pair X: r27:r26.
case 'X': case 'X':
return std::make_pair(unsigned(AVR::R27R26), &AVR::PTRREGSRegClass); if (VT == MVT::i8 || VT == MVT::i16)
return std::make_pair(unsigned(AVR::R27R26), &AVR::PTRREGSRegClass);
break;
case 'y': // Pointer register pair Y: r29:r28. case 'y': // Pointer register pair Y: r29:r28.
case 'Y': case 'Y':
return std::make_pair(unsigned(AVR::R29R28), &AVR::PTRREGSRegClass); if (VT == MVT::i8 || VT == MVT::i16)
return std::make_pair(unsigned(AVR::R29R28), &AVR::PTRREGSRegClass);
break;
case 'z': // Pointer register pair Z: r31:r30. case 'z': // Pointer register pair Z: r31:r30.
case 'Z': case 'Z':
return std::make_pair(unsigned(AVR::R31R30), &AVR::PTRREGSRegClass); if (VT == MVT::i8 || VT == MVT::i16)
return std::make_pair(unsigned(AVR::R31R30), &AVR::PTRREGSRegClass);
break;
default: default:
break; break;
} }
Context not available.