Page MenuHomePhabricator
Differential D91461 Diff 305304 llvm/lib/FileCheck/CMakeLists.txt

Changeset View

Standalone View

View Options

llvm/lib/FileCheck/CMakeLists.txt

add_llvm_component_library(LLVMFileCheck add_llvm_component_library(LLVMFileCheck
FileCheck.cpp FileCheck.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
"${LLVM_MAIN_INCLUDE_DIR}/llvm/FileCheck" "${LLVM_MAIN_INCLUDE_DIR}/llvm/FileCheck"
)
target_link_libraries(LLVMFileCheck LLVMSupport) LLVM_COMPONENTS
thopreUnsubmitted
Not Done
ReplyInline Actions

I don't see any LLVM_COMPONENTS in the source code, and llvm_add_library used indirectly by add_llvm_component_library knows about LINK_COMPONENTS but not LLVM_COMPONENTS. Is my source outdated and this was introduced recently?

thopre: I don't see any LLVM_COMPONENTS in the source code, and llvm_add_library used indirectly by…
MeinersburUnsubmitted
Not Done
ReplyInline Actions

I just noticed the inconsistent plural, not the LLVM_ prefix. Thanks that you noticed.

Meinersbur: I just noticed the inconsistent plural, not the `LLVM_` prefix. Thanks that you noticed.
Support
)
MeinersburUnsubmitted
Not Done
ReplyInline Actions

Isn't it LLVM_COMPONENTS?

Meinersbur: Isn't it LLVM_COMPONENT**S**?
thopreUnsubmitted
Not Done
ReplyInline Actions

or LINK_COMPONENTS?

thopre: or LINK_COMPONENTS?
serge-sans-pailleAuthorUnsubmitted
Done
ReplyInline Actions

Indeed :-)

serge-sans-paille: Indeed :-)