Page MenuHomePhabricator
Differential D90291 Diff 301619 clang-tools-extra/clangd/test/remote-index/pipeline.test

Changeset View

Standalone View

View Options

clang-tools-extra/clangd/test/remote-index/pipeline.test

  • This file was added.
# RUN: rm -rf %t
# RUN: clangd-indexer %S/Inputs/Source.cpp > %t.idx
kadircetUnsubmitted
Done
ReplyInline Actions

nit: / shouldn't be needed here.

the difference between %t and %/t is the latter is expressed with forward slashes on every platform.

kadircet: nit: `/` shouldn't be needed here. the difference between %t and %/t is the latter is…
# RUN: %python %S/pipeline_helper.py --input-file-name=%s --project-root=%S --index-file=%t.idx | FileCheck %s
kadircetUnsubmitted
Done
ReplyInline Actions

nit: s/.in.dex/.idx/

nit: maybe create a new Inputs directory under test/remote-index and move the files there?

kadircet: nit: s/.in.dex/.idx/ nit: maybe create a new `Inputs` directory under `test/remote-index` and…
# REQUIRES: clangd-remote-index
kadircetUnsubmitted
Done
ReplyInline Actions

use %python instead to enable lit substitution, just in case there are weird build bots without python on the PATH or the default one pointing at a wrong version.

can we use 127.0.0.1:50051 instead? as starting a server on 0.0.0.0 might be blocked on some bots again. And also I would rather use a random port number (greater than 1024, possibly by letting the python script choose the number, and getting rid of the argument completely), to lower the chances of failing accidentally when 50051 is in use. (it might be because bot is running multiple tests in parallel, or bot itself has a grpc server running on default port for whatever reason).

kadircet: use `%python` instead to enable lit substitution, just in case there are weird build bots…
ArcsinXUnsubmitted
Done
ReplyInline Actions

can we use 127.0.0.1:50051 instead?

I think we should do this, because we also pass this address into --remote-index-address= clangd parameter, which is illegal. Seems Linux and Mac allow to call connect with 0.0.0.0 as a destination address, but Windows does not and this test fails.

ArcsinX: > can we use 127.0.0.1:50051 instead? I think we should do this, because we also pass this…
kbobyrevAuthorUnsubmitted
Done
ReplyInline Actions

Thanks for checking! Can you try run this test now and see if it works?

kbobyrev: Thanks for checking! Can you try run this test now and see if it works?
ArcsinXUnsubmitted
Done
ReplyInline Actions

It works ok now.

ArcsinX: It works ok now.
ArcsinXUnsubmitted
Done
ReplyInline Actions

Is there any reason to use %/S in --project-root? We support --project-root with native slashes (at least --project-root=%S works for me on Windows + MS compiler)

It looks more reasonable to use %/S in paths like this %/S/Inputs/Source to avoid mixing slashes on Windows (but it works correctly with mixing slashes anyway)

ArcsinX: Is there any reason to use `%/S` in `--project-root`? We support `--project-root` with native…
{"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
# CHECK: "id": 0,
# CHECK-NEXT: "jsonrpc": "2.0",
---
{"jsonrpc":"2.0","id":1,"method":"workspace/symbol","params":{"query":"Character"}}
# CHECK: "id": 1,
# CHECK-NEXT: "jsonrpc": "2.0",
# CHECK-NEXT: "result": [
# CHECK-NEXT: {
# CHECK-NEXT: "containerName": "clang::clangd::remote",
# CHECK-NEXT: "kind": 13,
# CHECK-NEXT: "location": {
# CHECK-NEXT: "range": {
# CHECK-NEXT: "end": {
# CHECK-NEXT: "character": {{.*}},
# CHECK-NEXT: "line": {{.*}}
# CHECK-NEXT: },
# CHECK-NEXT: "start": {
# CHECK-NEXT: "character": {{.*}},
# CHECK-NEXT: "line": {{.*}}
# CHECK-NEXT: }
# CHECK-NEXT: },
# CHECK-NEXT: "uri": "file://{{.*}}/Header.h"
# CHECK-NEXT: },
# CHECK-NEXT: "name": "Character",
# CHECK-NEXT: "score": {{.*}}
# CHECK-NEXT: }
# CHECK-NEXT: ]
# CHECK-NEXT:}
---
{"jsonrpc":"2.0","id":4,"method":"shutdown"}
---
{"jsonrpc":"2.0","method":"exit"}
---