Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D89817 Diff 299441 llvm/include/llvm/IR/DIBuilder.h

Changeset View

Standalone View

View Options

llvm/include/llvm/IR/DIBuilder.h

Show First 20 Lines • Show All 488 Lines • ▼ Show 20 Lines DITemplateValueParameter *createTemplateParameterPack(DIScope *Scope,
DIType *Ty, DIType *Ty,
DINodeArray Val); DINodeArray Val);
/// Create debugging information entry for an array. /// Create debugging information entry for an array.
/// \param Size Array size. /// \param Size Array size.
/// \param AlignInBits Alignment. /// \param AlignInBits Alignment.
/// \param Ty Element type. /// \param Ty Element type.
/// \param Subscripts Subscripts. /// \param Subscripts Subscripts.
/// \param DataLocation Where to find the raw data of a Fortran array
aprantlUnsubmitted
Done
ReplyInline Actions

nit: . at the end please

aprantl: nit: `.` at the end please
/// \param Associated Where to find the associated attribute of a Fortran array.
aprantlUnsubmitted
Done
ReplyInline Actions

Please also document what kind of DINode is expected here.

aprantl: Please also document what kind of DINode is expected here.
/// \param Allocated Where to find the allocated attribute of a Fortran array.
DICompositeType *createArrayType(uint64_t Size, uint32_t AlignInBits, DICompositeType *createArrayType(uint64_t Size, uint32_t AlignInBits,
DIType *Ty, DINodeArray Subscripts); DIType *Ty, DINodeArray Subscripts,
Metadata *DataLocation = nullptr,
aprantlUnsubmitted
Not Done
ReplyInline Actions

Can these be any more specific DINode types?

aprantl: Can these be any more specific DINode types?
cchen15AuthorUnsubmitted
Not Done
ReplyInline Actions

These can be DIExpression, ConstantAsMetadata, etc, so Metadata looks to be the right specificity (and the underlying 'get' function it calls types them as Metadata too).

cchen15: These can be DIExpression, ConstantAsMetadata, etc, so Metadata looks to be the right…
Metadata *Associated = nullptr,
Metadata *Allocated = nullptr);
/// Create debugging information entry for a vector type. /// Create debugging information entry for a vector type.
/// \param Size Array size. /// \param Size Array size.
/// \param AlignInBits Alignment. /// \param AlignInBits Alignment.
aprantlUnsubmitted
Not Done
ReplyInline Actions

We could make this still strongly typed by either having two variants of the function or by using a PointerUnion<DIExpression, DIVariable> here.

aprantl: We could make this still strongly typed by either having two variants of the function or by…
cchen15AuthorUnsubmitted
Done
ReplyInline Actions

Thanks for pointing this out.

cchen15: Thanks for pointing this out.
/// \param Ty Element type. /// \param Ty Element type.
/// \param Subscripts Subscripts. /// \param Subscripts Subscripts.
DICompositeType *createVectorType(uint64_t Size, uint32_t AlignInBits, DICompositeType *createVectorType(uint64_t Size, uint32_t AlignInBits,
DIType *Ty, DINodeArray Subscripts); DIType *Ty, DINodeArray Subscripts);
/// Create debugging information entry for an /// Create debugging information entry for an
/// enumeration. /// enumeration.
/// \param Scope Scope in which this enumeration is defined. /// \param Scope Scope in which this enumeration is defined.
▲ Show 20 Lines • Show All 401 Lines • Show Last 20 Lines