Page MenuHomePhabricator
Differential D87774 Diff 296205 flang/test/Flang-Driver/driver-help.f90

Changeset View

Standalone View

View Options

flang/test/Flang-Driver/driver-help.f90

! RUN: %flang-new -help 2>&1 | FileCheck %s ! RUN: %flang-new -help 2>&1 | FileCheck %s --check-prefix=HELP
! RUN: %flang-new -fc1 -help 2>&1 | FileCheck %s ! RUN: %flang-new -fc1 -help 2>&1 | FileCheck %s --check-prefix=HELP-FC1
! RUN: not %flang-new -helps 2>&1 | FileCheck %s --check-prefix=ERROR ! RUN: not %flang-new -helps 2>&1 | FileCheck %s --check-prefix=ERROR
! REQUIRES: new-flang-driver ! REQUIRES: new-flang-driver
! CHECK:USAGE: flang-new ! HELP:USAGE: flang-new
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Should there be tests for gcc style as well?

kiranchandramohan: Should there be tests for gcc style as well?
awarzynskiAuthorUnsubmitted
Done
ReplyInline Actions

That's a good point,thanks! However, I'd like to defer this decision till later.

Currently we have enough options to support what is implemented in this driver. At some point we will need to have a discussion with regard to what options should be supported and displayed. This is not obvious to me just now. For example, Clang supports GCC style flags for diagnostic colors, but doesn't display them when running clang --help.

And once we do start discussing this in the context of Flang, any changes will very likely affect Clang too. I would prefer to focus on the required minimum before offering a complete set of supported option variants :)

awarzynski: That's a good point,thanks! However, I'd like to defer this decision till later. Currently we…
! CHECK-EMPTY: ! HELP-EMPTY:
! CHECK-NEXT:OPTIONS: ! HELP-NEXT:OPTIONS:
! CHECK-NEXT: -help Display available options ! HELP-NEXT: -fcolor-diagnostics Enable colors in diagnostics
! CHECK-NEXT: --version Print version information ! HELP-NEXT: -fno-color-diagnostics Disable colors in diagnostics
! HELP-NEXT: -help Display available options
! HELP-NEXT: --version Print version information
! ERROR: error: unknown argument '-helps'; did you mean '-help' ! HELP-FC1:USAGE: flang-new
! HELP-FC1-EMPTY:
! HELP-FC1-NEXT:OPTIONS:
! HELP-FC1-NEXT: -help Display available options
! HELP-FC1-NEXT: --version Print version information
! ERROR: flang-new: error: unknown argument '-helps'; did you mean '-help'