Differential D87774 Diff 296205 flang/include/flang/Frontend/TextDiagnosticPrinter.h

Changeset View

Standalone View

flang/include/flang/Frontend/TextDiagnosticPrinter.h

This file was added.

				//===--- TextDiagnosticPrinter.h - Text Diagnostic Client -------- C++ --===//
				//
				// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
				// See https://llvm.org/LICENSE.txt for license information.
				// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
				//
				//===----------------------------------------------------------------------===//
				//
				// This is a concrete diagnostic client. In terminals that support it, the
				// diagnostics are pretty-printed (colors + bold). The printing/flushing
				// happens in HandleDiagnostics (usually called at the point when the
				kiranchandramohanUnsubmitted Not Done Reply Inline Actions Where it prints depends on what stream is passed to the constructor of this class right? So is this standard error usage correct here? kiranchandramohan: Where it prints depends on what stream is passed to the constructor of this class right? So is…
				awarzynskiAuthorUnsubmitted Done Reply Inline Actions Good catch. I've updated this and also the description of `TextDiagnosticBuffer`. Hopefully that will make the distinction clearer. awarzynski: Good catch. I've updated this and also the description of `TextDiagnosticBuffer`. Hopefully…
				// diagnostic is generated).
				//
				//===----------------------------------------------------------------------===//

				kiranchandramohanUnsubmitted Done Reply Inline Actions Nit: Nos->NOS? kiranchandramohan: Nit: Nos->NOS?
				#ifndef LLVM_FLANG_FRONTEND_TEXTDIAGNOSTICPRINTER_H
				#define LLVM_FLANG_FRONTEND_TEXTDIAGNOSTICPRINTER_H

				#include "clang/Basic/Diagnostic.h"
				#include "llvm/ADT/IntrusiveRefCntPtr.h"
				#include "llvm/Support/raw_ostream.h"

				namespace clang {
				class DiagnosticOptions;
				class DiagnosticsEngine;
				}; // namespace clang

				using llvm::IntrusiveRefCntPtr;
				using llvm::raw_ostream;

				namespace Fortran::frontend {
				class TextDiagnostic;

				class TextDiagnosticPrinter : public clang::DiagnosticConsumer {
				raw_ostream &os_;
				llvm::IntrusiveRefCntPtr<clang::DiagnosticOptions> diagOpts_;

				/// A string to prefix to error messages.
				sameeranjoshiUnsubmitted Not Done Reply Inline Actions Where is this used? I don't see any reference. sameeranjoshi: Where is this used? I don't see any reference.
				awarzynskiAuthorUnsubmitted Done Reply Inline Actions We won't be needing this :) Thanks for catching this! awarzynski: We won't be needing this :) Thanks for catching this!
				std::string prefix_;

				public:
				TextDiagnosticPrinter(raw_ostream &os, clang::DiagnosticOptions *diags);
				~TextDiagnosticPrinter() override;

				/// Set the diagnostic printer prefix string, which will be printed at the
				/// start of any diagnostics. If empty, no prefix string is used.
				void set_prefix(std::string value) { prefix_ = std::move(value); }

				void HandleDiagnostic(clang::DiagnosticsEngine::Level level,
				CarolineConcattoUnsubmitted Not Done Reply Inline Actions style CarolineConcatto: style
				awarzynskiAuthorUnsubmitted Done Reply Inline Actions I think that this is correct as is: Accessor member functions are named with the non-public data member's name, less the trailing underscore. https://github.com/llvm/llvm-project/blob/master/flang/docs/C%2B%2Bstyle.md#naming 3rd point awarzynski: I think that this is correct as is: > Accessor member functions are named with the non-public…
				const clang::Diagnostic &info) override;
				};

				} // namespace Fortran::frontend

				#endif