Page MenuHomePhabricator
Differential D84334 Diff 287336 flang/tools/f18/CMakeLists.txt

Changeset View

Standalone View

View Options

flang/tools/f18/CMakeLists.txt

Context not available.
"__fortran_builtins" "__fortran_builtins"
) )
set(include ${FLANG_BINARY_DIR}/include/flang) target_include_directories(f18
sscalponeUnsubmitted
Not Done
ReplyInline Actions

Did this work for you?

CMake requires a PUBLIC or PRIVATE qualifier before the first directory argument.

I'm getting:

CMake Error at /local/home/sjs/llvm/llvm-project/flang/tools/f18/CMakeLists.txt:34 (target_include_directories):
  target_include_directories called with invalid arguments
sscalpone: Did this work for you? CMake requires a PUBLIC or PRIVATE qualifier before the first directory…
PRIVATE
set(include ${FLANG_BINARY_DIR}/include/flang) ${CMAKE_CURRENT_BINARY_DIR}
richard.barton.armUnsubmitted
Not Done
ReplyInline Actions

This is the line to reinstate.

richard.barton.arm: This is the line to reinstate.
)
DavidTrubyUnsubmitted
Not Done
ReplyInline Actions

as a small nit: I think target_include_directories(f18 ${CMAKE_CURRENT_BINARY_DIR}) is slightly cleaner. I'm not that fussed about it though

DavidTruby: as a small nit: I think `target_include_directories(f18 ${CMAKE_CURRENT_BINARY_DIR})` is…
# Create module files directly from the top-level module source directory # Create module files directly from the top-level module source directory
foreach(filename ${MODULES}) foreach(filename ${MODULES})
isurufUnsubmitted
Done
ReplyInline Actions

Can you use CMAKE_CURRENT_BINARY_DIR to configure the file? Source directory should be read only and not written to.

isuruf: Can you use `CMAKE_CURRENT_BINARY_DIR` to configure the file? Source directory should be read…
Context not available.
# The flang script to be installed needs a different path to the headers. # The flang script to be installed needs a different path to the headers.
set(FLANG_INTRINSIC_MODULES_DIR ${CMAKE_INSTALL_PREFIX}/include/flang) set(FLANG_INTRINSIC_MODULES_DIR ${CMAKE_INSTALL_PREFIX}/include/flang)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/flang.sh.in ${FLANG_BINARY_DIR}/bin/flang-install.sh @ONLY) configure_file(${CMAKE_CURRENT_SOURCE_DIR}/flang.sh.in ${FLANG_BINARY_DIR}/bin/flang-install.sh @ONLY)
sscalponeUnsubmitted
Not Done
ReplyInline Actions

Perhaps using FLANG_BINARY_DIR will fix the build?

sscalpone: Perhaps using FLANG_BINARY_DIR will fix the build?
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/f18_version.h.in ${CMAKE_CURRENT_BINARY_DIR}/f18_version.h @ONLY)
install(PROGRAMS ${FLANG_BINARY_DIR}/bin/flang-install.sh DESTINATION bin RENAME flang PERMISSIONS OWNER_EXECUTE OWNER_READ OWNER_WRITE) install(PROGRAMS ${FLANG_BINARY_DIR}/bin/flang-install.sh DESTINATION bin RENAME flang PERMISSIONS OWNER_EXECUTE OWNER_READ OWNER_WRITE)
Context not available.