Changeset View
Changeset View
Standalone View
Standalone View
llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
Show First 20 Lines • Show All 1,526 Lines • ▼ Show 20 Lines | for (const Function &F : M) { | ||||
if (F.isIntrinsic()) | if (F.isIntrinsic()) | ||||
continue; | continue; | ||||
// Handle the XCOFF case. | // Handle the XCOFF case. | ||||
// Variable `Name` is the function descriptor symbol (see above). Get the | // Variable `Name` is the function descriptor symbol (see above). Get the | ||||
// function entry point symbol. | // function entry point symbol. | ||||
MCSymbol *FnEntryPointSym = TLOF.getFunctionEntryPointSymbol(&F, TM); | MCSymbol *FnEntryPointSym = TLOF.getFunctionEntryPointSymbol(&F, TM); | ||||
if (cast<MCSymbolXCOFF>(FnEntryPointSym)->hasRepresentedCsectSet()) | |||||
jasonliu: After this change, do we still have any call to `hasRepresentedCsectSet`? If not, could we… | |||||
// Emit linkage for the function entry point. | // Emit linkage for the function entry point. | ||||
emitLinkage(&F, FnEntryPointSym); | emitLinkage(&F, FnEntryPointSym); | ||||
// Emit linkage for the function descriptor. | // Emit linkage for the function descriptor. | ||||
emitLinkage(&F, Name); | emitLinkage(&F, Name); | ||||
} | } | ||||
// Emit the remarks section contents. | // Emit the remarks section contents. | ||||
// FIXME: Figure out when is the safest time to emit this section. It should | // FIXME: Figure out when is the safest time to emit this section. It should | ||||
// not come after debug info. | // not come after debug info. | ||||
▲ Show 20 Lines • Show All 1,848 Lines • Show Last 20 Lines |
After this change, do we still have any call to hasRepresentedCsectSet? If not, could we remove that function all together?