Page MenuHomePhabricator
Differential D83623 Diff 277237 clang/lib/Driver/ToolChains/Clang.cpp

Changeset View

Standalone View

View Options

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,621 Lines • ▼ Show 20 Lines
RenderModulesOptions(C, D, Args, Input, Output, CmdArgs, HaveModules); RenderModulesOptions(C, D, Args, Input, Output, CmdArgs, HaveModules);
if (Args.hasFlag(options::OPT_fpch_validate_input_files_content, if (Args.hasFlag(options::OPT_fpch_validate_input_files_content,
options::OPT_fno_pch_validate_input_files_content, false)) options::OPT_fno_pch_validate_input_files_content, false))
CmdArgs.push_back("-fvalidate-ast-input-files-content"); CmdArgs.push_back("-fvalidate-ast-input-files-content");
if (Args.hasFlag(options::OPT_fpch_instantiate_templates, if (Args.hasFlag(options::OPT_fpch_instantiate_templates,
options::OPT_fno_pch_instantiate_templates, false)) options::OPT_fno_pch_instantiate_templates, false))
CmdArgs.push_back("-fpch-instantiate-templates"); CmdArgs.push_back("-fpch-instantiate-templates");
if (Args.hasFlag(options::OPT_fpch_codegen, options::OPT_fno_pch_codegen,
false)) {
CmdArgs.push_back("-fpch-codegen");
CmdArgs.push_back("-building-pch-with-obj");
}
if (Args.hasFlag(options::OPT_fpch_debuginfo, options::OPT_fno_pch_debuginfo,
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Perhaps these should map to -fmodules-codegen to simplify the frontend implementation?

(maybe the -fpch flags could be implemented as aliases for -fmodules*? Well, I guess -fmodules-codegen/debuginfo aren't driver options at the moment anyway - so if/when they do get promoted that can be handled then)

dblaikie: Perhaps these should map to -fmodules-codegen to simplify the frontend implementation? (maybe…
llunakAuthorUnsubmitted
Not Done
ReplyInline Actions

I don't know. Keeping it the same seems cleaner to me and it's just the tiny change in CompilerInvocation.cpp.

llunak: I don't know. Keeping it the same seems cleaner to me and it's just the tiny change in…
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Yeah, I could see it going either way - but we usually try to canonicalize in in the driver so there's less variation by the time it comes to the frontend. Please change this patch to only add a pch-debuginfo/pch-codegen driver option, not a cc1 option & leave the frontend support only using the modules-* naming.

dblaikie: Yeah, I could see it going either way - but we usually try to canonicalize in in the driver so…
false)) {
CmdArgs.push_back("-fpch-debuginfo");
CmdArgs.push_back("-building-pch-with-obj");
}
Args.AddLastArg(CmdArgs, options::OPT_fexperimental_new_pass_manager, Args.AddLastArg(CmdArgs, options::OPT_fexperimental_new_pass_manager,
options::OPT_fno_experimental_new_pass_manager); options::OPT_fno_experimental_new_pass_manager);
ObjCRuntime Runtime = AddObjCRuntimeArgs(Args, Inputs, CmdArgs, rewriteKind); ObjCRuntime Runtime = AddObjCRuntimeArgs(Args, Inputs, CmdArgs, rewriteKind);
RenderObjCOptions(TC, D, RawTriple, Args, Runtime, rewriteKind != RK_None, RenderObjCOptions(TC, D, RawTriple, Args, Runtime, rewriteKind != RK_None,
Input, CmdArgs); Input, CmdArgs);
▲ Show 20 Lines • Show All 1,527 Lines • Show Last 20 Lines