Page MenuHomePhabricator
Differential D80242 Diff 274636 clang/test/CodeGen/debug-info-unused-types.c

Changeset View

Standalone View

View Options

clang/test/CodeGen/debug-info-unused-types.c

  • This file was added.
// RUN: %clang -fno-eliminate-unused-debug-types -g -emit-llvm -S -o - %s | FileCheck %s
// RUN: %clang -feliminate-unused-debug-types -g -emit-llvm -S -o - %s | FileCheck --check-prefix=NODBG %s
// RUN: %clang -g -emit-llvm -S -o - %s | FileCheck --check-prefix=NODBG %s
// RUN: %clang -emit-llvm -S -o - %s | FileCheck --check-prefix=NODBG %s
typedef int my_int;
struct foo {};
enum bar { BAR };
union baz {};
void quux(void) {
typedef int x;
struct y {};
enum z { Z };
union w {};
}
// Check that debug info is emitted for the typedef, struct, enum, and union
// when -fno-eliminate-unused-debug-types and -g are set.
// CHECK: !DICompositeType(tag: DW_TAG_enumeration_type, name: "bar"
// CHECK: !DIEnumerator(name: "BAR"
// CHECK: !DICompositeType(tag: DW_TAG_enumeration_type, name: "z"
// CHECK: !DIEnumerator(name: "Z"
// CHECK: !DIDerivedType(tag: DW_TAG_typedef, name: "my_int"
// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "foo"
// CHECK: !DICompositeType(tag: DW_TAG_union_type, name: "baz"
// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "y"
// CHECK: !DICompositeType(tag: DW_TAG_union_type, name: "w"
// Check that debug info is not emitted for the typedef, struct, enum, and
dblaikieUnsubmitted
Done
ReplyInline Actions

Might be a smidge easier to read without the enumerators (& this doesn't check the enumerators are in the "elements" list of the enumeration anyway) - presumably the type emission codepath is well enough tested that we only need to to briefly test that the types were emitted at all? (might even be easy enough to stop after the tag and name))

dblaikie: Might be a smidge easier to read without the enumerators (& this doesn't check the enumerators…
// union when -fno-eliminate-unused-debug-types and -g are not set. These are
// the same checks as above with `NODBG-NOT` rather than `CHECK`.
// NODBG-NOT: !DICompositeType(tag: DW_TAG_enumeration_type, name: "bar"
// NODBG-NOT: !DIEnumerator(name: "BAR"
// NODBG-NOT: !DICompositeType(tag: DW_TAG_enumeration_type, name: "z"
// NODBG-NOT: !DIEnumerator(name: "Z"
// NODBG-NOT: !DIDerivedType(tag: DW_TAG_typedef, name: "my_int"
// NODBG-NOT: !DICompositeType(tag: DW_TAG_structure_type, name: "foo"
// NODBG-NOT: !DICompositeType(tag: DW_TAG_union_type, name: "baz"
// NODBG-NOT: !DICompositeType(tag: DW_TAG_structure_type, name: "y"
// NODBG-NOT: !DICompositeType(tag: DW_TAG_union_type, name: "w"
// Check that debug info is not emitted for declarations. Obnoxious
// indentifiers are to avoid collisions with the SHA emittied as debug info.
dblaikieUnsubmitted
Done
ReplyInline Actions

Could this be simplified down to:

NODBG-NOT: DICompositeType

?

dblaikie: Could this be simplified down to: ``` NODBG-NOT: DICompositeType ``` ?
struct aaaaaaaaaaaa;
enum bbbbbbbbbbbb;
union cccccccccccc;
void b0(void) {
struct dddddddddddd;
enum eeeeeeeeeeee;
union ffffffffffff;
}
// NODBG-NOT: aaaaaaaaaaaa
// NODBG-NOT: bbbbbbbbbbbb
// NODBG-NOT: cccccccccccc
// NODBG-NOT: dddddddddddd
// NODBG-NOT: eeeeeeeeeeee
// NODBG-NOT: ffffffffffff
dblaikieUnsubmitted
Done
ReplyInline Actions

Maybe give these more specific names (similarly in the other test) - and/or you could use a pattern in the naming that might make the -NOT lines easier?

eg:

struct decl_struct;
enum decl_enum;
...
// NODBG-NOT: name: "decl_

(also best to include a bit more context in the -NOT checks, otherwise there's risk that a users build directory (even with these longer names) or other paths might accidentally fail the checks)

dblaikie: Maybe give these more specific names (similarly in the other test) - and/or you could use a…