Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D81614 Diff 270290 llvm/lib/Object/TapiFile.cpp

Changeset View

Standalone View

View Options

llvm/lib/Object/TapiFile.cpp

Show All 34 Linesstatic uint32_t getFlags(const Symbol *Sym) {
if (Sym->isWeakDefined() || Sym->isWeakReferenced()) if (Sym->isWeakDefined() || Sym->isWeakReferenced())
Flags |= BasicSymbolRef::SF_Weak; Flags |= BasicSymbolRef::SF_Weak;
return Flags; return Flags;
} }
TapiFile::TapiFile(MemoryBufferRef Source, const InterfaceFile &interface, TapiFile::TapiFile(MemoryBufferRef Source, const InterfaceFile &interface,
Architecture Arch) Architecture Arch)
: SymbolicFile(ID_TapiFile, Source) { : SymbolicFile(ID_TapiFile, Source), Arch(Arch) {
for (const auto *Symbol : interface.symbols()) { for (const auto *Symbol : interface.symbols()) {
JDevlieghereUnsubmitted
Done
ReplyInline Actions

Why not do this in the initializer list?

JDevlieghere: Why not do this in the initializer list?
if (!Symbol->getArchitectures().has(Arch)) if (!Symbol->getArchitectures().has(Arch))
continue; continue;
switch (Symbol->getKind()) { switch (Symbol->getKind()) {
case SymbolKind::GlobalSymbol: case SymbolKind::GlobalSymbol:
Symbols.emplace_back(StringRef(), Symbol->getName(), getFlags(Symbol)); Symbols.emplace_back(StringRef(), Symbol->getName(), getFlags(Symbol));
break; break;
case SymbolKind::ObjectiveCClass: case SymbolKind::ObjectiveCClass:
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines