Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D80150 Diff 265830 lldb/unittests/Language/AppleObjC/UtilitiesTests.cpp

Changeset View

Standalone View

View Options

lldb/unittests/Language/AppleObjC/UtilitiesTests.cpp

  • This file was added.
//===-- UtilitiesTests.cpp ------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "Plugins/Language/ObjC/Utilities.h"
#include "lldb/Utility/StreamString.h"
#include "llvm/ADT/Optional.h"
#include "llvm/ADT/StringRef.h"
#include "gtest/gtest.h"
#include <cmath>
#include <string>
using namespace lldb_private;
// Try to format the date_value field of a NSDate.
static llvm::Optional<std::string> formatDateValue(double date_value) {
StreamString s;
bool succcess = formatters::NSDate::FormatDateValue(date_value, s);
if (succcess)
return std::string(s.GetData());
return llvm::None;
}
TEST(DataFormatterTest, NSDate) {
EXPECT_EQ(formatDateValue(-63114076800),
std::string("0001-12-30 00:00:00 +0000"));
// Assert that std::llrint clamps values greater/lesser than the max/min
// time_t values. If it doesn't, it won't make sense to proceed, as we're
// relying on this behavior to avoid float-cast-overflow UB.
const double greater_than_max_time = 1e200;
const double lesser_than_min_time = -1e200;
ASSERT_LE(static_cast<time_t>(std::llrint(greater_than_max_time)),
std::numeric_limits<time_t>::max());
ASSERT_GE(static_cast<time_t>(std::llrint(lesser_than_min_time)),
std::numeric_limits<time_t>::min());
// If the date_value `double` cannot be represented in a `time_t`, give up.
EXPECT_EQ(formatDateValue(greater_than_max_time), llvm::None);
labathUnsubmitted
Not Done
ReplyInline Actions

What about infinities and NaNs? (I can believe this will do the right thing for the former, but I have no clue what will happen in the NaN case).

labath: What about infinities and NaNs? (I can believe this will do the right thing for the former, but…
EXPECT_EQ(formatDateValue(lesser_than_min_time), llvm::None);
// If the date_value `double` plus the epoch cannot be represented in a
// `time_t`, give up. Try to craft a double that will trigger this scenario:
// if we can't do it, don't proceed.
const time_t date_value_to_trigger_overflow =
std::numeric_limits<time_t>::max() - formatters::GetOSXEpoch() + 1;
const double date_value_to_trigger_overflow_as_double =
static_cast<double>(date_value_to_trigger_overflow);
ASSERT_LE(date_value_to_trigger_overflow,
static_cast<time_t>(date_value_to_trigger_overflow_as_double));
EXPECT_EQ(formatDateValue(date_value_to_trigger_overflow_as_double),
llvm::None);
EXPECT_EQ(formatDateValue(0), std::string("2001-01-01 00:00:00 UTC"));
EXPECT_EQ(formatDateValue(1024), std::string("2001-01-01 00:17:04 UTC"));
}