Changeset View
Standalone View
llvm/CMakeLists.txt
| # See docs/CMake.html for instructions about how to build LLVM with CMake. | # See docs/CMake.html for instructions about how to build LLVM with CMake. | ||||
| cmake_minimum_required(VERSION 3.4.3) | cmake_minimum_required(VERSION 3.4.3) | ||||
| if ("${CMAKE_VERSION}" VERSION_LESS "3.13.4") | |||||
| message(WARNING | |||||
| "Your CMake version is ${CMAKE_VERSION}. Starting with LLVM 12.0.0, the " | |||||
smeenai: How about "Your CMake version" or "The CMake version you're using" or something like that… | |||||
| "minimum version of CMake required to build LLVM will become 3.13.4, and " | |||||
Not Done ReplyInline ActionsThis message refers to "internal process" concepts such as creation of a release branch. Can the message be made to be clear for "downstream consumers"? hubert.reinterpretcast: This message refers to "internal process" concepts such as creation of a release branch. Can… | |||||
Not Done ReplyInline ActionsI would write "Starting with 11.0, the minimum version of CMake required ...." mehdi_amini: I would write "Starting with 11.0, the minimum version of CMake required ...." | |||||
The reason why I didn't say a date is that I wasn't able to find the (approximate) date at which we'd branch off LLVM 11.0.0. It looks like this is around September, however, so I'll mention that if we keep the warning similar (see other threads).
It does read better, however it's not really what we mean. We'd have to say "Starting with 12.0, the minimum ...", which would be clear to downstream users of LLVM, but not to developers who will want to know that we're going to bump as soon as 11.0 is branched, even though 12.0 hasn't been released yet. I guess we could also lie and say "Starting with 11.0, ..." -- this would be clear to developers, and downstream users would think they need to upgrade when they could actually afford to wait one more release (which is probably OK). ldionne: @hubert.reinterpretcast
> This message refers to "internal process" concepts such as creation… | |||||
Not Done ReplyInline ActionsThe branch date is usually mid-July, and the release is late August/early September. I assume the branch date is what's relevant here. smeenai: The branch date is usually mid-July, and the release is late August/early September. I assume… | |||||
Not Done ReplyInline ActionsThe branch for 10.0 was created in January. The branch for 11.0 is likely to be created in July (six months since the last branch). The usual delay between branching and release is expected to put the release at September. I believe the "12.0" version of the wording is less likely to cause confusion if the 11.0 release is expected to be an opportunity for downstream users to learn of the planned change. If that's the direction, then we might want to put something into the 11.0 release notes to highlight the plan. hubert.reinterpretcast: The branch for 10.0 was created in January. The branch for 11.0 is likely to be created in July… | |||||
Not Done ReplyInline Actions@ldionne : I meant 12.0 here indeed. mehdi_amini: @ldionne : I meant 12.0 here indeed. | |||||
| "using an older CMake will become an error. Please upgrade your CMake to " | |||||
| "at least 3.13.4 now to avoid issues in the future!") | |||||
| endif() | |||||
| if(POLICY CMP0068) | if(POLICY CMP0068) | ||||
| cmake_policy(SET CMP0068 NEW) | cmake_policy(SET CMP0068 NEW) | ||||
| set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON) | set(CMAKE_BUILD_WITH_INSTALL_NAME_DIR ON) | ||||
| endif() | endif() | ||||
| if(POLICY CMP0075) | if(POLICY CMP0075) | ||||
| cmake_policy(SET CMP0075 NEW) | cmake_policy(SET CMP0075 NEW) | ||||
| endif() | endif() | ||||
| ▲ Show 20 Lines • Show All 1,101 Lines • Show Last 20 Lines | |||||
How about "Your CMake version" or "The CMake version you're using" or something like that, instead of "The current CMake version"? To me, "The current CMake version" is ambiguous – it could mean *your* current CMake version, or it could mean the minimum CMake version currently required by LLVM.