Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D69822 Diff 227942 clang/include/clang/Driver/Options.td

Changeset View

Standalone View

View Options

clang/include/clang/Driver/Options.td

Show First 20 Lines • Show All 1,946 Lines • ▼ Show 20 Lines
def fdebug_ranges_base_address: Flag <["-"], "fdebug-ranges-base-address">, Group<f_Group>, def fdebug_ranges_base_address: Flag <["-"], "fdebug-ranges-base-address">, Group<f_Group>,
Flags<[CC1Option]>, HelpText<"Use DWARF base address selection entries in debug_ranges">; Flags<[CC1Option]>, HelpText<"Use DWARF base address selection entries in debug_ranges">;
def fno_debug_ranges_base_address: Flag <["-"], "fno-debug-ranges-base-address">, Group<f_Group>, def fno_debug_ranges_base_address: Flag <["-"], "fno-debug-ranges-base-address">, Group<f_Group>,
Flags<[CC1Option]>; Flags<[CC1Option]>;
def fsplit_dwarf_inlining: Flag <["-"], "fsplit-dwarf-inlining">, Group<f_Group>, def fsplit_dwarf_inlining: Flag <["-"], "fsplit-dwarf-inlining">, Group<f_Group>,
Flags<[CC1Option]>, HelpText<"Provide minimal debug info in the object/executable to facilitate online symbolication/stack traces in the absence of .dwo/.dwp files when using Split DWARF">; Flags<[CC1Option]>, HelpText<"Provide minimal debug info in the object/executable to facilitate online symbolication/stack traces in the absence of .dwo/.dwp files when using Split DWARF">;
def fno_split_dwarf_inlining: Flag<["-"], "fno-split-dwarf-inlining">, Group<f_Group>, def fno_split_dwarf_inlining: Flag<["-"], "fno-split-dwarf-inlining">, Group<f_Group>,
Flags<[CC1Option]>; Flags<[CC1Option]>;
def fdwarf_default_version: Joined<["-"], "fdwarf-default-version=">, Group<f_Group>;
probinsonUnsubmitted
Done
ReplyInline Actions

If this is specifically the default DWARF version, I think the word "dwarf" ought to be in the option name.

probinson: If this is specifically the default DWARF version, I think the word "dwarf" ought to be in the…
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Can we haggle over this a bit?

My thinking behind -fdebug-default-version was consistency with other DWARF related flags:
-fdebug-compilation-dir
-fdebug-info-for-profiling
-fdebug-macro
-fdebug-types-section
-fdebug-ranges-base-address
-fdebug-prefix-map

We do have some -fdwarf:
-fdwarf2-cfi-asm
-fdwarf-directory-asm
-fdwarf-exceptions

So I'm personally inclined to sticking with -fdebug* as being all DWARF related/consistent there.

Thoughts?

dblaikie: Can we haggle over this a bit? My thinking behind -fdebug-default-version was consistency with…
probinsonUnsubmitted
Not Done
ReplyInline Actions

If the HelpText mentions DWARF, I'm okay with an -fdebug prefix.

probinson: If the HelpText mentions DWARF, I'm okay with an `-fdebug` prefix.
probinsonUnsubmitted
Not Done
ReplyInline Actions

Probably should have HelpText, maybe something like this:
"The default DWARF version to use, if a -g option causes DWARF debug info to be produced"
(it's probably not helpful to talk about overriding the target's default version, I think)

probinson: Probably should have HelpText, maybe something like this: "The default DWARF version to use, if…
dblaikieUnsubmitted
Not Done
ReplyInline Actions

Yep, I'd expect/be fine with all these options having something about DWARF in their long-form description.

@cmtice - would you mind switching this back to the original name & adding the relevant help text?

dblaikie: Yep, I'd expect/be fine with all these options having something about DWARF in their long-form…
probinsonUnsubmitted
Done
ReplyInline Actions

HelpText does not want a final period.

probinson: HelpText does not want a final period.
def fdebug_prefix_map_EQ def fdebug_prefix_map_EQ
: Joined<["-"], "fdebug-prefix-map=">, Group<f_Group>, : Joined<["-"], "fdebug-prefix-map=">, Group<f_Group>,
Flags<[CC1Option,CC1AsOption]>, Flags<[CC1Option,CC1AsOption]>,
HelpText<"remap file source paths in debug info">; HelpText<"remap file source paths in debug info">;
def fforce_dwarf_frame : Flag<["-"], "fforce-dwarf-frame">, Group<f_Group>, Flags<[CC1Option]>, def fforce_dwarf_frame : Flag<["-"], "fforce-dwarf-frame">, Group<f_Group>, Flags<[CC1Option]>,
HelpText<"Always emit a debug frame section">; HelpText<"Always emit a debug frame section">;
def fno_force_dwarf_frame : Flag<["-"], "fno-force-dwarf-frame">, Group<f_Group>, Flags<[CC1Option]>, def fno_force_dwarf_frame : Flag<["-"], "fno-force-dwarf-frame">, Group<f_Group>, Flags<[CC1Option]>,
HelpText<"Don't always emit a debug frame section">; HelpText<"Don't always emit a debug frame section">;
Show All 30 Lines
def gcodeview : Flag<["-"], "gcodeview">, def gcodeview : Flag<["-"], "gcodeview">,
HelpText<"Generate CodeView debug information">, HelpText<"Generate CodeView debug information">,
Flags<[CC1Option, CC1AsOption, CoreOption]>; Flags<[CC1Option, CC1AsOption, CoreOption]>;
def gcodeview_ghash : Flag<["-"], "gcodeview-ghash">, def gcodeview_ghash : Flag<["-"], "gcodeview-ghash">,
HelpText<"Emit type record hashes in a .debug$H section">, HelpText<"Emit type record hashes in a .debug$H section">,
Flags<[CC1Option, CoreOption]>; Flags<[CC1Option, CoreOption]>;
def gno_codeview_ghash : Flag<["-"], "gno-codeview-ghash">, Flags<[CoreOption]>; def gno_codeview_ghash : Flag<["-"], "gno-codeview-ghash">, Flags<[CoreOption]>;
def ginline_line_tables : Flag<["-"], "ginline-line-tables">, Flags<[CoreOption]>; def ginline_line_tables : Flag<["-"], "ginline-line-tables">, Flags<[CoreOption]>;
probinsonUnsubmitted
Done
ReplyInline Actions

Unexpected blank line here.

probinson: Unexpected blank line here.
def gno_inline_line_tables : Flag<["-"], "gno-inline-line-tables">, def gno_inline_line_tables : Flag<["-"], "gno-inline-line-tables">,
Flags<[CC1Option, CoreOption]>, HelpText<"Don't emit inline line tables">; Flags<[CC1Option, CoreOption]>, HelpText<"Don't emit inline line tables">;
def gfull : Flag<["-"], "gfull">, Group<g_Group>; def gfull : Flag<["-"], "gfull">, Group<g_Group>;
def gused : Flag<["-"], "gused">, Group<g_Group>; def gused : Flag<["-"], "gused">, Group<g_Group>;
def gstabs : Joined<["-"], "gstabs">, Group<g_Group>, Flags<[Unsupported]>; def gstabs : Joined<["-"], "gstabs">, Group<g_Group>, Flags<[Unsupported]>;
def gcoff : Joined<["-"], "gcoff">, Group<g_Group>, Flags<[Unsupported]>; def gcoff : Joined<["-"], "gcoff">, Group<g_Group>, Flags<[Unsupported]>;
def gxcoff : Joined<["-"], "gxcoff">, Group<g_Group>, Flags<[Unsupported]>; def gxcoff : Joined<["-"], "gxcoff">, Group<g_Group>, Flags<[Unsupported]>;
▲ Show 20 Lines • Show All 1,329 Lines • Show Last 20 Lines