Page MenuHomePhabricator
Differential D67613 Diff 220311 include/clang/AST/DeclCXX.h

Changeset View

Standalone View

View Options

include/clang/AST/DeclCXX.h

Context not available.
/// from the dwarf standard. /// from the dwarf standard.
enum LanguageIDs { enum LanguageIDs {
lang_c = /* DW_LANG_C */ 0x0002, lang_c = /* DW_LANG_C */ 0x0002,
lang_cxx = /* DW_LANG_C_plus_plus */ 0x0004 lang_cxx = /* DW_LANG_C_plus_plus */ 0x0004,
lang_cxx_11 = /* DW_LANG_C_plus_plus_11 */ 0x001a,
lang_cxx_14 = /* DW_LANG_C_plus_plus_14 */ 0x0021
aprantlUnsubmitted
Not Done
ReplyInline Actions

I understand that DWARF does not define a C++17 language constant, but in the AST I fell like we should represent it, even if it is being lowered into C++14 for the debug info.

aprantl: I understand that DWARF does not define a C++17 language constant, but in the AST I fell like…
SouraVXAuthorUnsubmitted
Done
ReplyInline Actions

It's represented in AST as enum in LangStandard.h file. We didn't add it here, as DWARF5 has no opcode for C++17. If we add it here some opcode, this might cause conflict with future upcoming DWARF standard.

SouraVX: It's represented in AST as enum in LangStandard.h file. We didn't add it here, as DWARF5 has no…
aprantlUnsubmitted
Not Done
ReplyInline Actions

Since these are the DWARF DW_lang constants, we shouldn't repeat their numeric values here. Can we write this as
lang_c = llvm::dwarf::DW_LANG_C, etc?

aprantl: Since these are the DWARF DW_lang constants, we shouldn't repeat their numeric values here. Can…
SouraVXAuthorUnsubmitted
Not Done
ReplyInline Actions

We can do this, but not sure whether, we should do this in AST ?
Since it's a language specific part, if we integrate this from DWARF opcodes it will unnecessary pollute AST ? Other language opcodes will also be visible here.

SouraVX: We can do this, but not sure whether, we should do this in AST ? Since it's a language specific…
aprantlUnsubmitted
Done
ReplyInline Actions

I'm not sure I understand the concern here. Are you worried about #Including "llvm/BinaryFormat/DWARF.h" and making these definitions visible to users of DeclCXX.h? All symbols there are in a separate namespace.

aprantl: I'm not sure I understand the concern here. Are you worried about #Including…
SouraVXAuthorUnsubmitted
Done
ReplyInline Actions

Thanks @aprantl for your review.
I was sceptical about, introducing DWARF related changes to AST, however you're correct, those are just language enums.
This will be heplfull in future, while adding language tag. If more C/C++ versions become part of DWARF standard.
Will address this change in next revision.

SouraVX: Thanks @aprantl for your review. I was sceptical about, introducing DWARF related changes to…
}; };
private: private:
Context not available.