Page MenuHomePhabricator
Differential D61967 Diff 200068 clang-tools-extra/clang-tidy/android/CloexecPipeCheck.h

Changeset View

Standalone View

View Options

clang-tools-extra/clang-tidy/android/CloexecPipeCheck.h

  • This file was added.
//===--- CloexecPipeCheck.h - clang-tidy-------------------------*- C++ -*-===//
//
Eugene.ZelenkoUnsubmitted
Done
ReplyInline Actions

Please extend to 80 characters. Same in source file.

Eugene.Zelenko: Please extend to 80 characters. Same in source file.
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ANDROID_CLOEXEC_PIPE_H
#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ANDROID_CLOEXEC_PIPE_H
#include "CloexecCheck.h"
namespace clang {
namespace tidy {
namespace android {
/// pipe() is better to be replaced by pipe2().
///
george.burgess.ivUnsubmitted
Done
ReplyInline Actions

nit: should probably update this comment

george.burgess.iv: nit: should probably update this comment
jcai19AuthorUnsubmitted
Done
ReplyInline Actions

Good catch!

jcai19: Good catch!
gribozavrUnsubmitted
Done
ReplyInline Actions

"Suggests to replace calls to pipe() with calls to pipe2()."

gribozavr: "Suggests to replace calls to pipe() with calls to pipe2()."
/// For the user-facing documentation see:
/// http://clang.llvm.org/extra/clang-tidy/checks/android-cloexec-pipe.html
class CloexecPipeCheck : public CloexecCheck {
public:
CloexecPipeCheck(StringRef Name, ClangTidyContext *Context)
: CloexecCheck(Name, Context) {}
void registerMatchers(ast_matchers::MatchFinder *Finder) override;
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
};
} // namespace android
} // namespace tidy
} // namespace clang
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ANDROID_CLOEXEC_PIPE_H