Page MenuHomePhabricator
Differential D45978 Diff 189843 test/Sema/dllexport-2.cpp

Changeset View

Standalone View

View Options

test/Sema/dllexport-2.cpp

  • This file was added.
// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -fsyntax-only -fms-extensions -verify %s
// RUN: %clang_cc1 -triple x86_64-pc-windows-msvc -fsyntax-only -fms-extensions -verify %s -DMSVC
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

I don't think we need this RUN line. I don't know if we need the triple in the previous RUN line either.

aaron.ballman: I don't think we need this RUN line. I don't know if we need the triple in the previous RUN…
// Export const variable.
#ifdef MSVC
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Another test I'd like to see is using a typedef to apply the const qualification. e.g.,

typedef const int CInt;
__declspec(dllexport) CInt j2;
__declspec(dllexport) CInt j3 = 3;

We should match the MSVC behavior here as well (I wonder if your use of isLocalConstQualified() should actually be isConstQualified() instead).

aaron.ballman: Another test I'd like to see is using a typedef to apply the const qualification. e.g., ```…
// expected-error@+6 {{default initialization of an object of const type 'const int'}}
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Please switch to #ifdef rather than #if.

aaron.ballman: Please switch to `#ifdef` rather than `#if`.
// expected-error@+5 {{'j' must have external linkage when declared 'dllexport'}}
#else
// expected-warning@+3 {{__declspec attribute 'dllexport' is not supported}}
// expected-error@+2 {{default initialization of an object of const type}}
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

I think the pattern to be used here is:

#ifdef MSVC
// expected-error@+4 {{'j' must have external linkage when declared 'dllexport'}}
#else
// expected-warning@+2 {{__declspec attribute 'dllexport' is not supported}}
#endif
__declspec(dllexport) int const j; // expected-error {{default initialization of an object of const type 'const int'}}
aaron.ballman: I think the pattern to be used here is: ``` #ifdef MSVC // expected-error@+4 {{'j' must have…
#endif
__declspec(dllexport) int const j;
// With typedef
typedef const int CInt;
#ifdef MSVC
// expected-error@+6 {{default initialization of an object of const type 'CInt' (aka 'const int')}}
// expected-error@+5 {{'j2' must have external linkage when declared 'dllexport'}}
#else
// expected-warning@+3 {{__declspec attribute 'dllexport' is not supported}}
// expected-error@+2 {{default initialization of an object of const type 'CInt'}}
#endif
__declspec(dllexport) CInt j2;
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

Same here as above.

aaron.ballman: Same here as above.
#ifndef MSVC
// expected-warning@+2 {{__declspec attribute 'dllexport' is not supported}}
#endif
aaron.ballmanUnsubmitted
Done
ReplyInline Actions

This isn't correct -- had the typo not been there, then the test would have failed because the file has diagnostics in MSVC mode. This should read:

#ifndef MSVC
// expected-warning@+2 {{__declspec attribute 'dllexport' is not supported}}
#endif
aaron.ballman: This isn't correct -- had the typo not been there, then the test would have failed because the…
__declspec(dllexport) CInt j3 = 3;