Page MenuHomePhabricator
Differential D55763 Diff 178621 src/DwarfParser.hpp

Changeset View

Standalone View

View Options

src/DwarfParser.hpp

Context not available.
break; break;
#endif #endif
mgornyUnsubmitted
Not Done
ReplyInline Actions
/var/tmp/portage/sys-libs/llvm-libunwind-9999/work/llvm-libunwind-9999/src/DwarfParser.hpp:686:75: error: macro "static_assert" requires 2 argument
s, but only 1 given                                                                                                                                
     static_assert(DW_CFA_AARCH64_negate_ra_state == DW_CFA_GNU_window_save);                                                                      
                                                                           ^
mgorny: ``` /var/tmp/portage/sys-libs/llvm-libunwind-9999/work/llvm-libunwind-9999/src/DwarfParser.hpp…
mclow.listsUnsubmitted
Not Done
ReplyInline Actions

Should this be wrapped in #ifdef _LIBUNWIND_TARGET_SPARC ?

mclow.lists: Should this be wrapped in `#ifdef _LIBUNWIND_TARGET_SPARC ` ?
dcedermanAuthorUnsubmitted
Not Done
ReplyInline Actions

Yes, it probably should. I will fix that.

dcederman: Yes, it probably should. I will fix that.
#if defined(_LIBUNWIND_TARGET_SPARC)
case DW_CFA_GNU_window_save:
for (reg = UNW_SPARC_O0; reg <= UNW_SPARC_O7; reg++) {
results->savedRegisters[reg].location = kRegisterInRegister;
results->savedRegisters[reg].value =
(reg - UNW_SPARC_O0) + UNW_SPARC_I0;
}
for (reg = UNW_SPARC_L0; reg <= UNW_SPARC_I7; reg++) {
results->savedRegisters[reg].location = kRegisterInCFA;
results->savedRegisters[reg].value = (reg - UNW_SPARC_L0) * 4;
}
_LIBUNWIND_TRACE_DWARF("DW_CFA_window_save()\n");
compnerdUnsubmitted
Not Done
ReplyInline Actions

Could you put this before the execution of the op please?

compnerd: Could you put this before the execution of the op please?
dcedermanAuthorUnsubmitted
Done
ReplyInline Actions

Sure. But for the other ops the trace printout is placed after the op, so this would break that pattern?

dcederman: Sure. But for the other ops the trace printout is placed after the op, so this would break that…
break;
#endif
default: default:
operand = opcode & 0x3F; operand = opcode & 0x3F;
switch (opcode & 0xC0) { switch (opcode & 0xC0) {
Context not available.