Differential D50478 Diff 166534 lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Changeset View

Standalone View

lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Show First 20 Lines • Show All 3,734 Lines • ▼ Show 20 Lines	while (die) {
if (parse_siblings)		if (parse_siblings)
die = die.GetSibling();		die = die.GetSibling();
else		else
die.Clear();		die.Clear();
}		}
return vars_added;		return vars_added;
}		}

		/// Collect call graph edges present in a function DIE.
		static std::vector<lldb_private::CallEdge>
		CollectCallEdges(DWARFDIE function_die) {
		// Check if the function has a supported call site-related attribute.
		// TODO: In the future it may be worthwhile to support call_all_source_calls.
		uint64_t has_call_edges =
		function_die.GetAttributeValueAsUnsigned(DW_AT_call_all_calls, 0);
		if (!has_call_edges)
		return {};

		Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_STEP));
		LLDB_LOG(log, "CollectCallEdges: Found call site info in {0}",
		function_die.GetPubname());

		// Scan the DIE for TAG_call_site entries.
		// TODO: A recursive scan of all blocks in the subprogram is needed in order
		// to be DWARF5-compliant. This may need to be done lazily to be performant.
		// For now, assume that all entries are nested directly under the subprogram
		// (this is the kind of DWARF LLVM produces) and parse them eagerly.
		sgraenitzUnsubmitted Not Done Reply Inline Actions Does any of the tests fail in case LLVM DWARFs change? Or is it very unlikely? sgraenitz: Does any of the tests fail in case LLVM DWARFs change? Or is it very unlikely?
		vskAuthorUnsubmitted Not Done Reply Inline Actions Yes, the tests in this patch would fail if TAG_call_site entries were nested within the nearest enclosing lexical block (as specified by DWARF 5). We would have a heads-up about such a breaking change. That said, it's unlikely to catch us by surprise, because we control the LLVM DWARF producer (see https://reviews.llvm.org/D49887). vsk: Yes, the tests in this patch would fail if TAG_call_site entries were nested within the nearest…
		std::vector<CallEdge> call_edges;
		for (DWARFDIE child = function_die.GetFirstChild(); child.IsValid();
		child = child.GetSibling()) {
		if (child.Tag() != DW_TAG_call_site)
		continue;

		// Extract DW_AT_call_origin (the call target's DIE).
		DWARFDIE call_origin = child.GetReferencedDIE(DW_AT_call_origin);
		if (!call_origin.IsValid()) {
		LLDB_LOG(log, "CollectCallEdges: Invalid call origin in {0}",
		function_die.GetPubname());
		continue;
		}

		// Extract DW_AT_call_return_pc (the PC the call returns to) if it's
		// available.
		addr_t return_pc = child.GetAttributeValueAsAddress(DW_AT_call_return_pc,
		LLDB_INVALID_ADDRESS);

		LLDB_LOG(log, "CollectCallEdges: Found call origin: {0} (return PC = {1})",
		call_origin.GetPubname(), return_pc);
		call_edges.emplace_back(call_origin.GetMangledName(), return_pc);
		}
		return call_edges;
		}

		std::vector<lldb_private::CallEdge>
		SymbolFileDWARF::ParseCallEdgesInFunction(UserID func_id) {
		DWARFDIE func_die = GetDIEFromUID(func_id.GetID());
		if (func_die.IsValid())
		return CollectCallEdges(func_die);
		return {};
		}

//------------------------------------------------------------------		//------------------------------------------------------------------
// PluginInterface protocol		// PluginInterface protocol
//------------------------------------------------------------------		//------------------------------------------------------------------
ConstString SymbolFileDWARF::GetPluginName() { return GetPluginNameStatic(); }		ConstString SymbolFileDWARF::GetPluginName() { return GetPluginNameStatic(); }

uint32_t SymbolFileDWARF::GetPluginVersion() { return 1; }		uint32_t SymbolFileDWARF::GetPluginVersion() { return 1; }

void SymbolFileDWARF::Dump(lldb_private::Stream &s) { m_index->Dump(s); }		void SymbolFileDWARF::Dump(lldb_private::Stream &s) { m_index->Dump(s); }
Show All 33 Lines